From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id 230761FF15F
	for <inbox@lore.proxmox.com>; Mon, 18 Nov 2024 10:24:20 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 8D7D8B2BE;
	Mon, 18 Nov 2024 10:24:25 +0100 (CET)
Message-ID: <5a17fc33-044e-455f-bffa-131ebc2fa907@proxmox.com>
Date: Mon, 18 Nov 2024 10:23:51 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
 Proxmox VE development discussion <pve-devel@lists.proxmox.com>
References: <20241115165753.2664489-1-a.lauterer@proxmox.com>
 <4e9520fa-c0ac-45e4-bcff-62b4b46198f7@proxmox.com>
Content-Language: en-US
From: Aaron Lauterer <a.lauterer@proxmox.com>
In-Reply-To: <4e9520fa-c0ac-45e4-bcff-62b4b46198f7@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.035 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] partially-applied: [PATCH widget-toolkit v7 0/4]
 fix #3893: make bridge vids configurable
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>



On  2024-11-16  16:41, Thomas Lamprecht wrote:
> Am 15.11.24 um 17:57 schrieb Aaron Lauterer:

> 
> 
> applied the widget toolkit with a few follow-ups to reduce code size and
> (try to) improve UX, maybe check them out to ensure nothing is off, thanks!

The UI changes, especially on the checks, seem to work as expected. Thanks!

> 
> The manager I also applied and adapted to my wtk changes, but FWICT you seem
> missing the backend validation for VIDs? So please add something similar to
> the UI checks there, if I did not overlook the checks happening in some other
> part of the call chain that is.

Those were all part of the earlier version and are already applied. 
Mainly in the register_format and accompanying validation function in 
pve-common.

https://git.proxmox.com/?p=pve-common.git;a=blobdiff;f=src/PVE/JSONSchema.pm;h=7c63af1c3f203944fb7e33fe3e1a5273c6f0361c;hp=ce390927b41894f3b681ec04beb73da571dae288;hb=0219596da20533e88c6638c593c66c302ad1218e;hpb=a8b8920d54595e2213292276e3cf77c0181fd894



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel