From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <f.ebner@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id C739E8AAAC
for <pve-devel@lists.proxmox.com>; Fri, 19 Aug 2022 12:08:31 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id B3D31191D9
for <pve-devel@lists.proxmox.com>; Fri, 19 Aug 2022 12:08:01 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pve-devel@lists.proxmox.com>; Fri, 19 Aug 2022 12:08:01 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 16C1443459;
Fri, 19 Aug 2022 12:08:01 +0200 (CEST)
Message-ID: <5a13fe68-3c53-b986-2c09-a80d31db225d@proxmox.com>
Date: Fri, 19 Aug 2022 12:08:00 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
Thunderbird/91.11.0
Content-Language: en-US
To: Matt Corallo <lpxdfsfs@mattcorallo.com>, pve-devel@lists.proxmox.com
References: <a5789fb9-b22a-a58a-9190-fa34e89c41a2@bluematt.me>
From: Fiona Ebner <f.ebner@proxmox.com>
In-Reply-To: <a5789fb9-b22a-a58a-9190-fa34e89c41a2@bluematt.me>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.046 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
NICE_REPLY_A -0.001 Looks like a legit reply (A)
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
T_SCC_BODY_TEXT_LINE -0.01 -
URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
information. [lxc.pm]
Subject: Re: [pve-devel] [PATCH] Update cpu.weight default to match
documented default
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Fri, 19 Aug 2022 10:08:31 -0000
Hi,
On 16.08.22 05:49, Matt Corallo wrote:
> Proxmox documentation describes the default CPU weight as 1024 in
> numerous places. However, when unset, the Linux default CGROUP
> weight is 100.
>
I'd rather update the documentation in all places, because most likely
it just wasn't adapted to mention the cgroup2 default yet. Some places
already do mention both defaults, e.g. 'man 5 qm.conf'
> This simply always writes an `lxc.cgroup2.cpu.weight` option to the
> LXC config file, defaulting to 1024 instead of omitting the option
> entirely.
>
> Signed-off-by: Matt Corallo <git@bluematt.me>
> ---
> src/PVE/LXC.pm | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
> index fe63087..ca453a9 100644
> --- a/src/PVE/LXC.pm
> +++ b/src/PVE/LXC.pm
> @@ -712,6 +712,9 @@ sub update_lxc_config {
> die "cpu weight (shares) must be in range [1, 10000]\n"
> if $shares < 1 || $shares > 10000;
> $raw .= "lxc.cgroup2.cpu.weight = $shares\n";
> + } else {
> + # Default as documented
> + $raw .= "lxc.cgroup2.cpu.weight = 1024\n";
> }
> }
>