From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <d.csapak@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with UTF8SMTPS id DA99475918 for <pve-devel@lists.proxmox.com>; Thu, 22 Apr 2021 10:11:45 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with UTF8SMTP id D1C2518C91 for <pve-devel@lists.proxmox.com>; Thu, 22 Apr 2021 10:11:45 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with UTF8SMTPS id 5B29518C84 for <pve-devel@lists.proxmox.com>; Thu, 22 Apr 2021 10:11:45 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with UTF8SMTP id 2E813462FF; Thu, 22 Apr 2021 10:11:45 +0200 (CEST) Message-ID: <595c2f64-51a9-6298-eb6a-77cbe16e5460@proxmox.com> Date: Thu, 22 Apr 2021 10:11:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:88.0) Gecko/20100101 Thunderbird/88.0 Content-Language: en-US To: Thomas Lamprecht <t.lamprecht@proxmox.com>, Proxmox VE development discussion <pve-devel@lists.proxmox.com> References: <20210422063902.26490-1-d.csapak@proxmox.com> <3fca81fe-ae3e-088b-5c22-1245db0e8e29@proxmox.com> From: Dominik Csapak <d.csapak@proxmox.com> In-Reply-To: <3fca81fe-ae3e-088b-5c22-1245db0e8e29@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.000 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] applied: [PATCH manager v2] ui: Utils: change default Console order for vms X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Thu, 22 Apr 2021 08:11:45 -0000 On 4/22/21 10:02, Thomas Lamprecht wrote: > On 22.04.21 08:39, Dominik Csapak wrote: >> we want to use spice for vms more than xtermjs if both are available >> (since spice must be chosen as display in that case) >> so the resulting order of preference for vms is: >> spice >> xtermjs >> novnc >> >> since all methods work for containers always, there we use >> xtermjs by default, or what is chosen in the datacenter option >> >> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com> >> --- >> changes from v1: >> * fixed the default so that it is only 'vv' for vms, not other >> types of consoles (shell, upgrade,..) >> >> www/manager6/Utils.js | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> > > applied, thanks! But wondering if form VMs noVNC should be the next in line, > as long as the display property of the VM is not set to a serialX console. > could be nice, but would require adaptation in the status api call (we only return if a serial terminal is there, not the vm config)