From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id EA3FE93F97 for ; Thu, 8 Feb 2024 12:32:59 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CF2E51C58D for ; Thu, 8 Feb 2024 12:32:59 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 8 Feb 2024 12:32:58 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 91FB0451AE for ; Thu, 8 Feb 2024 12:32:58 +0100 (CET) Message-ID: <591f4a5b-42aa-4568-b9f8-33ecd59aadcc@proxmox.com> Date: Thu, 8 Feb 2024 12:32:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Christoph Heiss Cc: Proxmox VE development discussion References: <20240123170053.490250-1-a.lauterer@proxmox.com> Content-Language: en-US From: Aaron Lauterer In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.065 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH v1 installer/docs 00/18] add automated/unattended installation X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Feb 2024 11:33:00 -0000 On 2/8/24 11:34, Christoph Heiss wrote: > On Thu, Feb 08, 2024 at 11:26:01AM +0100, Christoph Heiss wrote: >> Did some testing, doing various installs using >> * different filesystems >> * pre/post hooks >> * simple udev matching for disks and network interfaces >> >> I did not exercise the udev-matching exhaustively, but as it is pretty >> generic, that should cover it. >> >> The `proxmox-installer-filter` is a nice tooling addition as well! >> Maybe we could also provide some tool in the future which would do some >> (basic) sanity checking/validating on the `answer.toml`, to avoid people >> having to do test cycles on a real machine. good point. I guess just checking if it parses without errors is okay for a first version. Will work on something for v3. >> >> As for the global `{pre,post}_commands` hooks - , > Whoops, got a bit cut of here. In any case; a though of mine: > For the post-hook (at least), these run after the installation has > completely finished. So changing anything inside the new installation - > for which this hook could be pretty useful - can only be done in a > rather hacky way. > > This probably should be some future addition on its own, but maybe > provide the user also with some hook to modify the newly installed > system, possibly running the commands inside a chroot? Or simply passing > the (mount) path via environment variable or such. > > But this will need some deeper hooking into to the installation code - > just spilling my thoughts here. yeah, we had the idea floating around of providing a small tool similar to "arch-chroot" to easily chroot into the installation. > >> >> So please consider this: >> >> Tested-by: Christoph Heiss >> >> Also, already left some review comments on the individual patches, but >> nothing too major. >> >> On Tue, Jan 23, 2024 at 06:00:35PM +0100, Aaron Lauterer wrote: > [..]