From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 795B11FF141 for ; Tue, 19 May 2026 14:06:28 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 330395072; Tue, 19 May 2026 14:06:26 +0200 (CEST) Message-ID: <59190ec5-5dea-49c5-8fe3-c52351d5a407@proxmox.com> Date: Tue, 19 May 2026 14:06:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH pve-network v2] sdn: frr: add bgpd to SDN-managed daemons To: Hannes Laimer , pve-devel@lists.proxmox.com References: <20260519092537.19326-1-h.laimer@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20260519092537.19326-1-h.laimer@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779192368234 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.069 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: JLDEF5GAK3WQN7LS2YDA2SDBURDBVDXN X-Message-ID-Hash: JLDEF5GAK3WQN7LS2YDA2SDBURDBVDXN X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 5/19/26 11:25 AM, Hannes Laimer wrote: > Every sdn-apply on a node that has a BGP fabric configured trips the > set_daemon_status() guard with "bgpd is not SDN managed", aborting FRR > config generation. The Rust enabled_daemons() reports bgpd for BGP > fabrics, but the Perl allowlist was only updated for OSPF and OpenFabric > when those fabric types were originally added. > > Default bgpd to enabled, unlike ospfd and fabricd: the BGP and EVPN > controllers also depend on bgpd and do not manage /etc/frr/daemons > themselves, so removing the last BGP fabric must not silently disable > bgpd on a system where a controller still needs it. > > Fixes: 9d8533d ("sdn: fabrics: register bgp as a fabric protocol type") > Signed-off-by: Hannes Laimer > --- Just ran into this while testing and can confirm this fixes the SDN network reload on apply. FWIW, consider: Tested-by: Christian Ebner