From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 22E3A1FF13B for ; Wed, 20 May 2026 16:00:39 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3E48EA2B4; Wed, 20 May 2026 16:00:36 +0200 (CEST) Message-ID: <58f70cc4-2aa1-4e02-97f1-448868036948@proxmox.com> Date: Wed, 20 May 2026 16:00:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH network] ui: sdn: fabrics: drop dead disabled bindings To: Gabriel Goller , pve-devel@lists.proxmox.com References: <20260520125125.251655-1-g.goller@proxmox.com> Content-Language: en-US From: Thomas Lamprecht In-Reply-To: <20260520125125.251655-1-g.goller@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779285616001 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.004 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: IC7QIW6GMNBHWY7ZZNRAFGAJXZLY562Y X-Message-ID-Hash: IC7QIW6GMNBHWY7ZZNRAFGAJXZLY562Y X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 20.05.26 um 14:51 schrieb Gabriel Goller: > The prefix fields used an invalid cbind setup for their disabled state, > so the bindings didn't work and editing the fabric prefix was possible. > > Initially we didn't want the user to be able to update the prefix of a > fabric, because we would need to add a mechanism to update all the node > ips at the same time. This broke though and they became editable -- > which is fine, since you still get an error "node has ip out of prefix". > Keep it this way, because editing a fabric without nodes is still > useful. > > Remove the dead disabled bindings while keeping deleteEmpty handling. > > Fixes: e5e3374273af ("ui: fabrics: edit: make ipv4/6 support generic over fabric panels") > Signed-off-by: Gabriel Goller > --- > www/manager6/sdn/fabrics/FabricEdit.js | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/www/manager6/sdn/fabrics/FabricEdit.js b/www/manager6/sdn/fabrics/FabricEdit.js > index 46c8dd6b0c86..1f7bab362075 100644 > --- a/www/manager6/sdn/fabrics/FabricEdit.js > +++ b/www/manager6/sdn/fabrics/FabricEdit.js > @@ -62,10 +62,7 @@ Ext.define('PVE.sdn.Fabric.Fabric.Edit', { > name: 'ip_prefix', > allowBlank: true, > skipEmptyText: true, > - cbind: { > - disabled: '{!isCreate}', > - deleteEmpty: '{!isCreate}', > - }, > + deleteEmpty: '{!isCreate}', using that template syntax only makes sense inside a bind (viewModel) or cbind (config bind), but you move them out of there, so this is not basically a literal string. Should be rather changed to a literal true or false or just dropped > }); > } > > @@ -86,10 +83,7 @@ Ext.define('PVE.sdn.Fabric.Fabric.Edit', { > name: 'ip6_prefix', > allowBlank: true, > skipEmptyText: true, > - cbind: { > - disabled: '{!isCreate}', > - deleteEmpty: '{!isCreate}', > - }, > + deleteEmpty: '{!isCreate}', same here > listeners: { > change: function (textbox, value) { > let vm = textbox.up('window').getViewModel();