From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A6512932C2 for ; Mon, 19 Feb 2024 15:00:27 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 821CF30AEA for ; Mon, 19 Feb 2024 14:59:57 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 19 Feb 2024 14:59:56 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B6DCC436C9; Mon, 19 Feb 2024 14:59:56 +0100 (CET) Message-ID: <589fa91d-13c1-412d-b991-e3b338f0549d@proxmox.com> Date: Mon, 19 Feb 2024 14:59:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Thomas Lamprecht , Proxmox VE development discussion References: <20231207133558.566788-1-d.csapak@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.020 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] applied: [PATCH manager v2] fix #5106: ui: ceph status: make column wrap the summary text on expand X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Feb 2024 14:00:27 -0000 On 2/19/24 14:57, Thomas Lamprecht wrote: > Am 07/12/2023 um 14:35 schrieb Dominik Csapak: >> with this the title is now completely visible when the column is >> expanded, even if it's originally too narrow. >> >> Suggested-by: Thomas Lamprecht >> Signed-off-by: Dominik Csapak >> --- >> changes from v1: >> * wrap the text in the column, instead of duplicating it in the expanded >> body >> >> thanks @thomas for the suggestion >> >> www/css/ext6-pve.css | 4 ++++ >> www/manager6/ceph/Status.js | 16 ++++++++++++++++ >> 2 files changed, 20 insertions(+) >> >> > > applied, with Fiona's T-b and the fix for the eslint warning squashed in, > thanks! > > btw. I first tried `pve-eslint --fix .` inside the (clean) www/manager6 > folder, but that just resulted in a truncated ceph/Status.js file, so while > eslint seems to correctly get the fix option and finds the issue, writing > out the updated code to the file seems broken – can you look into that? > (no pressure though) i guess you meant me with that ;) yes i can look into that