From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 90CA871580 for ; Wed, 8 Jun 2022 15:33:03 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7EA8A947C for ; Wed, 8 Jun 2022 15:32:33 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 8CBD99470 for ; Wed, 8 Jun 2022 15:32:31 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 5A13943693; Wed, 8 Jun 2022 15:32:31 +0200 (CEST) Message-ID: <5893ce79-408c-b4e8-751b-40a0d39c8e83@proxmox.com> Date: Wed, 8 Jun 2022 15:32:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Content-Language: en-US To: Daniel Bowder Cc: Proxmox VE development discussion References: <20220608115428.250668-1-daniel@bowdernet.com> <7b52e845-3bc7-01b3-6882-358739a6d5b9@proxmox.com> From: Matthias Heiserer In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.704 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -1.732 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pve-devel] [PATCH 0/5] fix #3593: Added vm core pinning X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jun 2022 13:33:03 -0000 On 08.06.2022 15:21, Daniel Bowder wrote: >> Thank you for your patches! > You are welcome. > >> Regarding the formatting: Please make sure to follow our Perl and >> Javascript style guides [0][1] and the Developer Documentation [2]. All >> your patches use a nonconformant indentation :/ > I do apologize for that. I read [0] and [2] in their entirety multiple > times. I was very careful to make sure I didn't have any lines that were > > 100 chars and I tried to follow the formatting guidelines. I'll need to fix > my editor to match the indentation specifications. No worries, the formatting is a bit unusual. > >> Also, the repository (e.g. qemu-server) should be part of the prefix, >> next to "PATCH", this makes it easier to parse where they belong. > The instructions on [2] under #Preparing_Patches are a little ambiguous > when it comes to changes to multiple repos that are all related. > Specifically when making changes to multiple repos for one related task. > > # cd pve-manager; git format-patch -s -o /tmp/patchq -1 > # cd ../pve-guest-common; git format-patch -s -o /tmp/patchq -1 > # cd ../pve-docs; git format-patch -s -o /tmp/patchq -1 > # git send-email --compose --to=pve-devel@lists.proxmox.com /tmp/patchq/* > > I didn't follow these completely blindly, but, I also wasn't 100% certain > what to change for a multi-repo review vs a single repo review. I'll make > sure to include [ PATCH xxxx a/b ] for each xxxx repo patch in the future. > >> In case you haven't done so yet, we require a CLA (explained in [2]) >> from you in order to use your code. > I sent in the CLA just before submitting the patches. Great!> > I'm somewhat of a noob when it comes to mailing lists as opposed to working > off of branches in a repo. Do I resubmit my patches in the same way that I > did previously after I've resolved the indentation issues? > Yes, exactly! Make sure to also add a version in the commit message(e.g: "[pve-devel] [PATCH v2 pve-manager 4/5] fix #3593"), and describe which changes were made since the last version. You can take a look at other mails so see how it is done: https://lists.proxmox.com/pipermail/pve-devel/, and in the Developer Documentation in the section "Preparing Patches". I suggest you wait a bit before sending in a v2, I'll first test your patch. > On Wed, Jun 8, 2022 at 6:00 AM Matthias Heiserer > wrote: > >> On 08.06.2022 13:54, Daniel Bowder wrote: >>> These five patches add the ability to pin a QEMU VMs processes to a >> defined set of CPU cores. The changes required spanned multiple repos and >> have all been included in these five patches. The patches add "cpuset" as >> an option in the qm configuration file and enable the editing of this >> parameter via the gui. >>> >> >> Thank you for your patches! >> >> Regarding the formatting: Please make sure to follow our Perl and >> Javascript style guides [0][1] and the Developer Documentation [2]. All >> your patches use a nonconformant indentation :/ >> Also, the repository (e.g. qemu-server) should be part of the prefix, >> next to "PATCH", this makes it easier to parse where they belong. >> >> In case you haven't done so yet, we require a CLA (explained in [2]) >> from you in order to use your code. >> >> >> [0] https://pve.proxmox.com/wiki/Perl_Style_Guide >> [1] https://pve.proxmox.com/wiki/Javascript_Style_Guide >> [2] https://pve.proxmox.com/wiki/Developer_Documentation >> >> >