From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id D67861FF17C
	for <inbox@lore.proxmox.com>; Wed,  2 Apr 2025 17:16:10 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id B79A01E14E;
	Wed,  2 Apr 2025 17:15:57 +0200 (CEST)
Message-ID: <587b5ac2-1f8b-437b-91e6-52a4b5142235@proxmox.com>
Date: Wed, 2 Apr 2025 17:15:24 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
 Fiona Ebner <f.ebner@proxmox.com>
References: <20250401173435.221892-1-f.ebner@proxmox.com>
Content-Language: en-US
From: Friedrich Weber <f.weber@proxmox.com>
In-Reply-To: <20250401173435.221892-1-f.ebner@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.010 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH-SERIES
 qemu/storage/qemu-server/container/manager v7 00/37] backup provider API
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

Hi, I tried v7 very quickly with the backup-provider-dir-example
storage. Some minor things I noticed below, IMO nothing that can't be
fixed in follow-ups.

Note that I didn't look too closely how the backup provider API really
works, so some of the following may just be consequences of the example
backup-provider-dir-example plugin being an example plugin, in this case
feel free to ignore:

- naively triggering a one-off VM backup fails with "ERROR: cannot setup
backup access without fleecing". I understand why and this is nothing
critical, but I can imagine this could cause some confusion (e.g. if
users don't immediately read the relevant ERROR line of the task log).
Might be nice to either allow enabling fleecing also for one-off
backups, or disable the "Backup Now" button for external storages.

- I needed to install nbdfuse and modprobe nbd -- might be nice to do
both automatically somehow (though packages of external backup plugins
could probably add nbdfuse as a dependency?)

- by accident I let the destination filesystem run full, which resulted
in a stuck backup task and the following message being spammed to the
journal:

> Apr 02 16:46:34 pve-backupprovider kernel: block nbd0: Other side
returned error (28)

Maybe there is a way to abort the backup in such a case?

- the VM backup wrote out the full 32G disk image including zeroes to
the qcow2, but from a quick look at the source this is probably
expected? Restoring this backup to e.g. lvm-thin gets rid of the zeroes
again, though.

- navigating to a VM backup on the backup-provider-dir-example storage
and clicking on "Edit Notes" fails with

> failed to stat 'PVE::Storage::Custom::BackupProviderDirExamplePlugin'
(500)

and the following message in the journal:

> Apr 02 17:04:38 pve-backupprovider pvedaemon[960]: file_size_info:
detected call without $file_format parameter


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel