From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 860EE1FF1C8 for ; Fri, 24 Apr 2026 14:19:31 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3ED4318A05; Fri, 24 Apr 2026 14:12:03 +0200 (CEST) Message-ID: <585d77ce-5bc6-43a5-9644-8b1a7b1f21ec@proxmox.com> Date: Fri, 24 Apr 2026 14:11:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: superseded: [PATCH-SERIES qemu-server v3 00/18] fix #7066: api: allow live snapshot (remove) of qcow2 TPM drive with snapshot-as-volume-chain To: Lukas Sichert , pve-devel@lists.proxmox.com References: <20260423093753.43199-1-f.ebner@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1777032598152 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.009 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: PACYSYA6VDJ22C2L6NVMUUIIJ72V3FKM X-Message-ID-Hash: PACYSYA6VDJ22C2L6NVMUUIIJ72V3FKM X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 24.04.26 um 1:58 PM schrieb Lukas Sichert: > I went through the code and the changes look good overall, just > two small nits: > > The git history is somewhat confusing. Changes introduced in one > commit are modified again in later commits. This would be > completely fine if it ensured that the codebase remains in a > consistent state after each commit, but as already discussed in > [1], this is not always the case. That said, the series works > correctly once applied in full. > > Also, in my opinion, 'qsd_qmp_peer' would be a better name than > 'qsd_peer' to make it explicit that this refers to a QMP peer > and to keep naming consistent with 'vm_qmp_peer'. > > > [1] lore.proxmox.com/pve-devel/DI0L56K45KJK.1G3MBGPZI2KJV@proxmox.com/T/#m7e7ffe8240f4092755e27c6072e0e27ffcdd96b5 Sorry, was a bit too eager with sending v4. I added the rename as an optional follow-up there too now. superseded-by: <20260424114722.107671-1-f.ebner@proxmox.com>