From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 587F61FF56B for ; Mon, 22 Apr 2024 10:28:14 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6846BADBC; Mon, 22 Apr 2024 10:28:17 +0200 (CEST) Message-ID: <5812c09b-78c6-41db-b235-8d80329b45b5@proxmox.com> Date: Mon, 22 Apr 2024 10:28:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Fiona Ebner To: Proxmox VE development discussion , Dominik Csapak References: <20240422081646.838784-1-d.csapak@proxmox.com> <20240422081646.838784-2-d.csapak@proxmox.com> <65e5354b-5187-4157-8240-e76fe056e203@proxmox.com> Content-Language: en-US In-Reply-To: <65e5354b-5187-4157-8240-e76fe056e203@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -1.368 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy ENA_SUBJ_ODD_CASE 2.6 Subject has odd case KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager v2 2/2] ui: use pveTwoColumnContainer for the advanced backup options X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 22.04.24 um 10:22 schrieb Fiona Ebner: > Am 22.04.24 um 10:16 schrieb Dominik Csapak: >> where we generally want to show a field on the left, but a description >> on the right. >> >> merges the column1/2/B into just items. >> >> Signed-off-by: Dominik Csapak > > Getting eslint errors: > >> [./panel/BackupAdvancedOptions.js]: >> WARN: line 158 col 16: key-spacing - Missing space before value for key 'endWidget'. (*) >> WARN: line 161 col 7: comma-dangle - Missing trailing comma. (*) > > I noticed that the "Fallback (default)" emptytext does not fit in the > value fields. Could you improve the spacing there? > Other than that, both patches: Tested-by: Fiona Ebner Reviewed-by: Fiona Ebner _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel