From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2C31E6AB01 for ; Thu, 17 Mar 2022 09:35:35 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 17FA52FEEC for ; Thu, 17 Mar 2022 09:35:05 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 817432FEE1 for ; Thu, 17 Mar 2022 09:35:04 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3BFE5428AA; Thu, 17 Mar 2022 09:35:04 +0100 (CET) Message-ID: <5803a37d-7308-1e0d-89f7-fc80c9b297d8@proxmox.com> Date: Thu, 17 Mar 2022 09:35:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:99.0) Gecko/20100101 Thunderbird/99.0 Content-Language: en-US To: "DERUMIER, Alexandre" , "pve-devel@lists.proxmox.com" , "aderumier@odiso.com" References: <20220306124647.2267293-1-aderumier@odiso.com> <20220306124647.2267293-2-aderumier@odiso.com> <07ccbada79379fd6677c61d495995eed957b34af.camel@groupe-cyllene.com> From: Thomas Lamprecht In-Reply-To: <07ccbada79379fd6677c61d495995eed957b34af.camel@groupe-cyllene.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.057 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH V2 qemu-server 1/2] enable balloon free-page-reporting X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Mar 2022 08:35:35 -0000 On 16.03.22 20:32, DERUMIER, Alexandre wrote: > From my tests: > a already booted vm without the balloon freepage option enabled ---> > migrating to new vm with balloon freepage option enabled : works > > Then failback it to previous node : works > > > But starting a new vm with the option enabled then migrate it to a new > vm withtout the option: > > migration die on resume. > > 2022-03-16 20:28:30 average migration speed: 1.5 GiB/s - downtime 30 ms > 2022-03-16 20:28:30 migration status: completed > 2022-03-16 20:28:30 ERROR: tunnel replied 'ERR: resume failed - VM 104 > not running' to command 'resume 104' > 2022-03-16 20:28:39 ERROR: migration finished with problems (duration > 00:00:18) > TASK ERROR: migration problems > I now tested with a Debian Testing (bookworm) VM and ensured it actually logs "Free page reporting enabled" in the kernel log and you're right it fails there. But that's only relevant for migrating a VM that got freshly started (!) on a new (upgraded) host and then gets migrated to an old one, and that's something we never supported anyway (besides some very light best-effort). As the VM doesn't even crashes then, and just fails to migrate (source VM stays running), it's not even problematic for that case; the admin can just upgrade the qemu-server on the other node already and continue. Same holds for live-snapshots, only a snasphot from a freshly started VM on an already upgraded host would cause issues on rollback, but *only* on an old host, so the same as any QEMU update would cause anyway. So, it seems we can just enable it with 6.2 as machine guard and be done. > > If think this is because guest kernel balloon driver enabled it at boot > only. > yeah seems so. > > Note that I don't think that current windows drivers already support it > (I have looked at the source code, so even if the option is enabled at > qemu level, it don't do nothing inside windows. > So I think that migration will works in both direction with windows > vms.