From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id 048131FF163
	for <inbox@lore.proxmox.com>; Thu, 21 Nov 2024 16:16:04 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 77DA27E4;
	Thu, 21 Nov 2024 16:16:10 +0100 (CET)
Message-ID: <57c8bdb5-c688-44f3-805a-2dabcb1577a6@proxmox.com>
Date: Thu, 21 Nov 2024 16:16:06 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
From: Hannes Laimer <h.laimer@proxmox.com>
To: pve-devel@lists.proxmox.com
References: <20241115100037.25177-1-h.laimer@proxmox.com>
Content-Language: en-US
In-Reply-To: <20241115100037.25177-1-h.laimer@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.024 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH qemu-server] fix #3588: helper: consider NIC
 count for config-specific timeout
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

sent a v2 [1]

[1] 
https://lore.proxmox.com/pve-devel/20241121151335.130711-1-h.laimer@proxmox.com/T/#u

On 11/15/24 11:00, Hannes Laimer wrote:
> There have been some reports about `qm start` timeouts on VMs that have a
> lot of NICs assigned.
> This patch considers the number of NICs when calculating the config-specific
> timeout. Since the increase in start time is linearly related to the number
> of NICs, a constant timeout increment per NIC was chosen.
> 
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
>   PVE/QemuServer/Helpers.pm | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/PVE/QemuServer/Helpers.pm b/PVE/QemuServer/Helpers.pm
> index 0afb6317..99cb3ab8 100644
> --- a/PVE/QemuServer/Helpers.pm
> +++ b/PVE/QemuServer/Helpers.pm
> @@ -167,6 +167,14 @@ sub config_aware_timeout {
>   	$timeout = 150;
>       }
>   
> +    # Some testing showed that adding a NIC increased the start time by ~450ms
> +    # consistantly across different NIC models, options and already existsing
> +    # number of NICs.
> +    # So, 10x that to account for any potential system differences seemed
> +    # reasonable.
> +    my $nic_count = grep { /^net/ } keys %{$config};
> +    $timeout += $nic_count * 5;
> +
>       return $timeout;
>   }
>   



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel