From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 198FF1FF195 for <inbox@lore.proxmox.com>; Fri, 7 Mar 2025 14:01:34 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 70FB01B2D4; Fri, 7 Mar 2025 14:01:27 +0100 (CET) Message-ID: <5745e3ff-83ac-4a79-9f58-f37086dbd5b1@proxmox.com> Date: Fri, 7 Mar 2025 14:00:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Dominik Csapak <d.csapak@proxmox.com> References: <20250213131716.3062383-1-d.csapak@proxmox.com> <20250213131716.3062383-15-d.csapak@proxmox.com> Content-Language: en-US From: Fiona Ebner <f.ebner@proxmox.com> In-Reply-To: <20250213131716.3062383-15-d.csapak@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.041 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [entry.id, pci.pm] Subject: Re: [pve-devel] [PATCH manager v6 1/5] mapping: pci: include mdev in config checks X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> Am 13.02.25 um 14:17 schrieb Dominik Csapak: > by also providing the global config in assert_valid, and by also > adding the mdev config in the 'toCheck' object in the gui > > For the gui, we extract the mdev property from the global entry, and add > it to the individual mapping entries, that way we can reuse the checking > logic of the other properties. > > Signed-off-by: Dominik Csapak <d.csapak@proxmox.com> Reviewed-by: Fiona Ebner <f.ebner@proxmox.com> > --- > no changes in v6 > PVE/API2/Cluster/Mapping/PCI.pm | 2 +- > www/manager6/dc/PCIMapView.js | 6 ++++++ > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/PVE/API2/Cluster/Mapping/PCI.pm b/PVE/API2/Cluster/Mapping/PCI.pm > index 64462d25..f85623bb 100644 > --- a/PVE/API2/Cluster/Mapping/PCI.pm > +++ b/PVE/API2/Cluster/Mapping/PCI.pm > @@ -115,7 +115,7 @@ __PACKAGE__->register_method ({ > }; > } > for my $mapping ($mappings->@*) { > - eval { PVE::Mapping::PCI::assert_valid($id, $mapping) }; > + eval { PVE::Mapping::PCI::assert_valid($id, $mapping, $entry) }; > if (my $err = $@) { > push $entry->{checks}->@*, { > severity => 'error', > diff --git a/www/manager6/dc/PCIMapView.js b/www/manager6/dc/PCIMapView.js > index 80fe3c0f..f9d43aa2 100644 > --- a/www/manager6/dc/PCIMapView.js > +++ b/www/manager6/dc/PCIMapView.js > @@ -20,10 +20,15 @@ Ext.define('PVE.dc.PCIMapView', { > data.forEach((entry) => { > ids[entry.id] = entry; > }); Nit: maybe worth a brief code comment here (e.g. what you already wrote in the commit message). > + let mdev; > me.getRootNode()?.cascade(function(rec) { > + if (rec.data.type === 'entry') { > + mdev = rec.data.mdev ?? 0; > + } > if (rec.data.node !== node || rec.data.type !== 'map') { > return; > } > + rec.data.mdev = mdev; > > let id = rec.data.path; > if (!id.match(/\.\d$/)) { > @@ -44,6 +49,7 @@ Ext.define('PVE.dc.PCIMapView', { > let toCheck = { > id: deviceId, > 'subsystem-id': subId, > + mdev: device.mdev ?? 0, > iommugroup: device.iommugroup !== -1 ? device.iommugroup : undefined, > }; > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel