From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 241711FF161 for ; Tue, 10 Sep 2024 11:37:31 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F22FB318EB; Tue, 10 Sep 2024 11:37:29 +0200 (CEST) Message-ID: <5742e006-6d8d-4a54-9b12-69b614461b64@proxmox.com> Date: Tue, 10 Sep 2024 11:37:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Aaron Lauterer References: <20240729115540.191594-1-a.lauterer@proxmox.com> <20240729115540.191594-4-a.lauterer@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20240729115540.191594-4-a.lauterer@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.058 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH common v4 3/7] inotify: interfaces: make sure bridge_vids use space as separator X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 29.07.24 um 13:55 schrieb Aaron Lauterer: > Because the API accepts multiple possible list separators we need to > make sure that we write the bridge_vids with space as separator, no > matter which separator was used when passing it to the API. > Nit: The reason why it's necessary to write out with space as the separator is missing. Who gets confused otherwise ;)? Should we do the conversion earlier, i.e. in the API endpoint when writing the interface parameters? Like that we don't end up carrying the invalid value around. > Signed-off-by: Aaron Lauterer > Tested-By: Stefan Hanreich > Reviewed-by: Shannon Sterz Still: Reviewed-by: Fiona Ebner _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel