From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2D66D92330 for ; Mon, 12 Sep 2022 11:44:15 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 169D63209 for ; Mon, 12 Sep 2022 11:43:45 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 12 Sep 2022 11:43:44 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4837A42DB4 for ; Mon, 12 Sep 2022 11:43:44 +0200 (CEST) Message-ID: <573b120f-4b30-b9c1-f870-5345ad1fbc41@proxmox.com> Date: Mon, 12 Sep 2022 11:43:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:105.0) Gecko/20100101 Thunderbird/105.0 Content-Language: en-GB To: Proxmox VE development discussion , Leo Nunner References: <20220909114539.61612-1-l.nunner@proxmox.com> <784d7bc5-3e6a-eeb1-2928-d3a71d3b054b@proxmox.com> From: Thomas Lamprecht In-Reply-To: <784d7bc5-3e6a-eeb1-2928-d3a71d3b054b@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 2.049 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -4.101 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH container] fix #4192: add new architecture-dependent path to check for newer versions of systemd X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2022 09:44:15 -0000 On 12/09/2022 11:30, Dominik Csapak wrote: > On 9/12/22 11:30, Dominik Csapak wrote: >>>>   # non systemd based containers work with pure cgroupv2 >>>>   sub unified_cgroupv2_support { >>>> -    my ($self) = @_; >>>> +    my ($self, $conf) = @_; >>> >>> why pass the whole config if you just need the arch? Please avoid overly generic >>> parameter in signatures if only one specific thing is required. >>> >> >> AFAICS, not even that is necessary, since a 'LXC::Setup' object has the config in self >> so we could do there a '$self->{confg}->{arch}' and omit the parameter passing completely > > i meant '$self->{conf}->{arch}' ofc > >> (or am i missing something else here?) This is the plugin though, where $self isn't LXC::Setup but basing off LXC::Setup::Plugin, and there we don't have any $conf object available, and we explicitly pass $conf to those methods in most case, which I'd guess is where Leo copied this off from. Still, I'd like to avoid that pattern for newer adaptions if possible, iow. if only using up two or three config params at max, as heuristic.