From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BA687737A3 for ; Tue, 6 Jul 2021 17:49:29 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AC86D24A4B for ; Tue, 6 Jul 2021 17:49:29 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 7FB6424A3A for ; Tue, 6 Jul 2021 17:49:28 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4C30F40E52 for ; Tue, 6 Jul 2021 17:49:28 +0200 (CEST) Message-ID: <5739cae5-409f-10fc-9f48-d7661ad325ee@proxmox.com> Date: Tue, 6 Jul 2021 17:49:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:90.0) Gecko/20100101 Thunderbird/90.0 Content-Language: en-US To: Proxmox VE development discussion , Fabian Ebner References: <20210706134729.84973-1-f.ebner@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210706134729.84973-1-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.508 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [storage.pm] Subject: [pve-devel] applied: [PATCH storage] extract backup config: less precise matching for broken pipe detection X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Jul 2021 15:49:29 -0000 On 06.07.21 15:47, Fabian Ebner wrote: > Extracting the config for zstd compressed vma files was broken: > Failed to extract config from VMA archive: zstd: error 70 : Write > error : cannot write decoded block : Broken pipe (500) > since the error message changed and wouldn't match anymore. > > Signed-off-by: Fabian Ebner > --- > > Hotfix for now, isn't there a better way to properly handle this? meh, properly handling it is a bit of a PITA and that's why we landed here, which, short of style fixing in the output like with zstd here, served us surprisingly well. Properly would probably mean one of: * make the vma tool understand the compressions, adding in quite some libraries for that single use case, so not too ideal.. * saving the config in some other way, e.g., outside of the archive, so that we either reverse the pipe direction (vma gets config blob and then decompresses it) or avoid compression for the, rather small config file completely * adding a control fd to VMA where it can tell that it closed OK, that way we could ignore any error if we get an OK written from vma to that FD. That wouldn't sound to bad actually, but did not really thought it out.. > PVE/Storage.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > for now that'll do, applied, thanks!