From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 68285632C5 for ; Thu, 24 Feb 2022 13:33:23 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5D1A77AD4 for ; Thu, 24 Feb 2022 13:33:23 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 426B07AC7 for ; Thu, 24 Feb 2022 13:33:22 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1770046E3F for ; Thu, 24 Feb 2022 13:33:22 +0100 (CET) Message-ID: <56e39079-4d65-575b-631a-2f2f508cca35@proxmox.com> Date: Thu, 24 Feb 2022 13:33:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:98.0) Gecko/20100101 Thunderbird/98.0 Content-Language: en-US To: Proxmox VE development discussion , Matthias Heiserer References: <20220224104559.382734-1-m.heiserer@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20220224104559.382734-1-m.heiserer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.057 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemuserver.pm] Subject: [pve-devel] applied: [PATCH qemu-server v4] fix 3886: QEMU restore: verify storage allows images before writing X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Feb 2022 12:33:23 -0000 On 24.02.22 11:45, Matthias Heiserer wrote: > When restoring a backup and the storage the disks would be created on > doesn't allow 'images', the process errors without cleanup. > This is the same behaviour we currently have when the storage is > disabled. > > Adds the Datastore.AllocateSpace check to cloudinit drives. that belongs in a separate patch, I split that out. > > Signed-off-by: Matthias Heiserer Please pick up T-b/R-b tags from earlier reviews if the patch did not change substantially in between - thx! > --- > Thanks to Fabian! > Changes from v3: > + Restore a line I accidentally deleted > > Changes from v2: > + Also check Datastore.AllocateSpace permissions for cloudinit device > + Move content type check closer to allocate permission check > > Changes from v1: > + Check content type for cloud init drives > > PVE/QemuServer.pm | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > applied, thanks! Followed up with using a closure for the shared checks, not less lines of code but slightly less noise in the looping over backup config part.