From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E5D1E9241F for ; Wed, 12 Oct 2022 10:57:29 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CEAF62411A for ; Wed, 12 Oct 2022 10:57:29 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 12 Oct 2022 10:57:28 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 35E394467B for ; Wed, 12 Oct 2022 10:57:28 +0200 (CEST) Message-ID: <56868828-dac3-945a-c3af-d2fcf32bc2f7@proxmox.com> Date: Wed, 12 Oct 2022 10:57:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 To: pve-devel@lists.proxmox.com References: <20220520080332.80155-1-o.bektas@proxmox.com> Content-Language: en-US From: Daniel Tschlatscher In-Reply-To: <20220520080332.80155-1-o.bektas@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.311 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -2.934 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH v6 manager] ui: vm network: allow to override MTU for virtio devices X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Oct 2022 08:57:30 -0000 This patch still applies well and works as intended. There is one UI suggestion inline. Tested-by: Daniel Tschlatscher On 5/20/22 10:03, Oguz Bektas wrote: > we already have the 'mtu' option in the API, so we can just expose > that option inside the 'Advanced' menu for virtio network interfaces. > > Signed-off-by: Oguz Bektas > --- > www/manager6/qemu/NetworkEdit.js | 34 ++++++++++++++++++++++++++++++++ > 1 file changed, 34 insertions(+) > > v5->v6: > * move the MTU bar to the left column, kept the message tooltip on the > right one> * minor syntax changes from thomas' review on v5 > > diff --git a/www/manager6/qemu/NetworkEdit.js b/www/manager6/qemu/NetworkEdit.js > index b39cffdc..d9f9b859 100644 > --- a/www/manager6/qemu/NetworkEdit.js > +++ b/www/manager6/qemu/NetworkEdit.js > @@ -19,6 +19,7 @@ Ext.define('PVE.qemu.NetworkInputPanel', { > me.network.macaddr = values.macaddr; > me.network.disconnect = values.disconnect; > me.network.queues = values.queues; > + me.network.mtu = values.mtu; > > if (values.rate) { > me.network.rate = values.rate; > @@ -33,6 +34,17 @@ Ext.define('PVE.qemu.NetworkInputPanel', { > return params; > }, > > + viewModel: { > + data: { > + networkModel: '', > + mtu: '', > + }, > + formulas: { > + isVirtio: get => get('networkModel') === 'virtio', > + showMtuHint: get => get('mtu') === 1, > + }, > + }, > + > setNetwork: function(confid, data) { > var me = this; > > @@ -93,6 +105,18 @@ Ext.define('PVE.qemu.NetworkInputPanel', { > fieldLabel: gettext('Disconnect'), > name: 'disconnect', > }, > + { > + xtype: 'proxmoxintegerfield', > + name: 'mtu', > + fieldLabel: 'MTU', > + bind: { > + disabled: '{!isVirtio}', > + value: '{mtu}', > + }, > + minValue: 1, > + maxValue: 65520, > + allowBlank: true, > + }, > ]; > > if (me.insideWizard) { > @@ -112,6 +136,7 @@ Ext.define('PVE.qemu.NetworkInputPanel', { > 'macaddr', > 'rate', > 'queues', > + 'mtu', > ]; > fields.forEach(function(fieldname) { > me.down('field[name='+fieldname+']').setDisabled(value); > @@ -130,6 +155,7 @@ Ext.define('PVE.qemu.NetworkInputPanel', { > xtype: 'pveNetworkCardSelector', > name: 'model', > fieldLabel: gettext('Model'), > + bind: '{networkModel}', > value: PVE.qemu.OSDefaults.generic.networkCard, > allowBlank: false, > }, > @@ -161,6 +187,14 @@ Ext.define('PVE.qemu.NetworkInputPanel', { > value: '', > allowBlank: true, > }, > + { > + xtype: 'displayfield', > + userCls: 'pmx-hint', > + value: gettext("Use the special value '1' to inherit the MTU value from the underlying bridge"), > + bind: { > + hidden: '{!showMtuHint}', > + }, > + }, I think it might make a bit more sense to move this into the advancedColumn1 as well, as now it is displayed in the opposite column, which makes the UI flow kind of confusing. Perhaps an even better option though, would be to move the displayfield into an advancedColumnB, which would also remove the line width limit and with it the somewhat ugly line break. > ]; > > me.callParent();