From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <f.ebner@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id D4F2790BD6
for <pve-devel@lists.proxmox.com>; Mon, 19 Dec 2022 12:23:22 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id B884226FCF
for <pve-devel@lists.proxmox.com>; Mon, 19 Dec 2022 12:23:22 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pve-devel@lists.proxmox.com>; Mon, 19 Dec 2022 12:23:21 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 91CBD4489F
for <pve-devel@lists.proxmox.com>; Mon, 19 Dec 2022 12:23:21 +0100 (CET)
Message-ID: <564d84e1-95e0-b3d7-16e3-3df55143d0dc@proxmox.com>
Date: Mon, 19 Dec 2022 12:23:20 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
Thunderbird/102.5.0
Content-Language: en-US
To: pve-devel@lists.proxmox.com, s.sterz@proxmox.com
References: <20221219111446.219468-1-s.sterz@proxmox.com>
From: Fiona Ebner <f.ebner@proxmox.com>
In-Reply-To: <20221219111446.219468-1-s.sterz@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.601 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
NICE_REPLY_A -1.148 Looks like a legit reply (A)
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH qemu-server v2] cdrom handling: default to
"none" if no physical drive is available
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Mon, 19 Dec 2022 11:23:22 -0000
Am 19.12.22 um 12:14 schrieb Stefan Sterz:
> when a vm is configured to use the physical cd rom drive but there is
> no such drive a cryptic "uninitialized value" error is thrown. this
> is due to `$path` not being defined in `sub
> print_drive_commandline_full` in this case. warn that no cd rom drive
> is available and default back to using "none" as media instead.
>
> note that the error was basically cosmetic as the vm would start just
> fine.
>
> forum thread: https://forum.proxmox.com/threads/119592/
>
> Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
> ---
> changes from v1: make the error message more concise. use shorter
> forum link for better formatting in commit message (thanks @
> Fiona Ebner).
>
> PVE/QemuServer.pm | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
> index dd6ea3e..d2f2094 100644
> --- a/PVE/QemuServer.pm
> +++ b/PVE/QemuServer.pm
> @@ -1292,6 +1292,9 @@ sub get_cdrom_path {
> return $cdrom_path = "/dev/cdrom" if -l "/dev/cdrom";
> return $cdrom_path = "/dev/cdrom1" if -l "/dev/cdrom1";
> return $cdrom_path = "/dev/cdrom2" if -l "/dev/cdrom2";
> +
> + warn "no physical cdrom available, defaulting back to 'none'";
It's still having the very same issues as in v1.
> + return '';
> }
>
> sub get_iso_path {