From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id AEBEB71B15 for ; Fri, 13 May 2022 09:55:19 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A5F502EF3D for ; Fri, 13 May 2022 09:55:19 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id B9B9F2EF34 for ; Fri, 13 May 2022 09:55:18 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 861A9434DD for ; Fri, 13 May 2022 09:55:18 +0200 (CEST) Message-ID: <56094244-2673-e153-7945-2063767cd189@proxmox.com> Date: Fri, 13 May 2022 09:55:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Content-Language: en-US To: Thomas Lamprecht , Proxmox VE development discussion References: <20220506123910.146775-1-d.tschlatscher@proxmox.com> <1390d06b-f06a-2518-8d99-5cb074abb9f2@proxmox.com> From: Daniel Tschlatscher In-Reply-To: <1390d06b-f06a-2518-8d99-5cb074abb9f2@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.396 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -2.888 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] applied: [PATCH manager v2] fix #3994: Options menu entry in the System menu X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 May 2022 07:55:19 -0000 On 5/12/22 17:13, Thomas Lamprecht wrote: > Am 5/6/22 um 14:39 schrieb Daniel Tschlatscher: >> Add the subentry "Options" in the "System" menu to expose some options >> in the GUI which were not exposed before. >> >> Added a new file for displaying and editing the node config options >> which were not exposed through the GUI yet. Namely those are the >> settings for wakeonlan and startall-on-boot-delay. Edited the Makefile >> to include the newly created file. >> >> Signed-off-by: Daniel Tschlatscher >> --- >> Changes from v2: >> >> - Moved the file from the widget-toolkit to the pve-manager repository >> because it implements PVE specific functionality. >> - I originally rewrote this class to use a ViewController, but then >> found out that the ObjectGrid does most of what I wanted already, I >> just had to address it correctly. >> This means the code is now a bit shorter and a lot more concise. >> >> www/manager6/Makefile | 1 + >> www/manager6/node/Config.js | 9 ++++ >> www/manager6/node/NodeOptionsView.js | 67 ++++++++++++++++++++++++++++ >> 3 files changed, 77 insertions(+) >> create mode 100644 www/manager6/node/NodeOptionsView.js >> >> > applied, thanks! > > I moved it one item below, as IMO DNS and Host are too related to be split by some > general "Options" navigation entry. > > Some other points to improve: > > - setting the online help, maybe to 'proxmox_node_management' which would make > it point to: > https://pve.proxmox.com/pve-docs/chapter-sysadmin.html#proxmox_node_management > (the chapter could maybe do good with some addition w.r.t. first start delay This sounds to me like a suggestion to set the online help for the panel, i.e. the button in the top right corner. But that's already included in the patch. Or are you suggesting to put it somewhere else too? > > - It's not clear what unit the start delay has, you could mention that explicitly, > simplest way to do so is adding a ' (s)' to the fieldLabel after the gettext. The field does not display a value while displaying Default, though it explicitly states 'Seconds' after any value is set. I think it would become very clear to anybody then what unit this setting represents. Still, adding ' (s)' probably wouldn't kill me either. 😉 > > - Wake on LAN could do with a "Local MAC Address" emptyText, combined with the > onlineHelp button it should then be clear enough. That's a very good suggestion, I will look into it. > > can you please look into those? > > FYI and not directly related: > if we ever expose the vzdump.conf options over GUI I'd also add them here in this > panel, as subpanel; would be a good use of all that empty space ;-) Noted.