From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 21D7799484 for ; Thu, 16 Nov 2023 11:45:31 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 093EA11C36 for ; Thu, 16 Nov 2023 11:45:31 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 16 Nov 2023 11:45:30 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2704A437B3 for ; Thu, 16 Nov 2023 11:45:30 +0100 (CET) Message-ID: <55edb79e-7276-4612-9961-c297e15bdb33@proxmox.com> Date: Thu, 16 Nov 2023 11:45:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Fiona Ebner , Proxmox VE development discussion References: <20231115160042.177037-1-p.hufnagl@proxmox.com> <20231115160042.177037-5-p.hufnagl@proxmox.com> <6fcfa1ac-6796-48a3-8942-9b548be31c98@proxmox.com> From: Philipp Hufnagl In-Reply-To: <6fcfa1ac-6796-48a3-8942-9b548be31c98@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.054 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH storage v2 4/4] pbs: fix #5008: Check if datastore and namespace is valid on add- and update hooks X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2023 10:45:31 -0000 On 11/16/23 10:57, Fiona Ebner wrote: > Am 15.11.23 um 17:00 schrieb Philipp Hufnagl: >> @@ -831,10 +855,27 @@ sub check_datastore_exists { >> return 1; >> } >> } >> - >> die "$storeid: Cannot find datastore '$datastore', check permissions and existence!\n"; >> } >> >> +sub check_namespace_exists { >> + my ($class, $storeid, $scfg, $password, $conn) = @_; >> + >> + my $datastore = $scfg->{datastore}; >> + my $namespace = $scfg->{namespace}; >> + >> + my $namespaces = eval { scan_namespaces($scfg, $datastore, $password) }; > > You're not actually re-using the connection, because it's not passed > along here. > > Ideally, the fix would've been ordered first and the connection re-use > refactoring later. Like this, the fix cannot be applied independently of > all that. Thanks for noticing. I was trying to order the commits in a way that, while they are changing the code, the should not impact the behavior of the program. It should be possible to apply all previous commits without modifying the behavior. If it is easier or maintainers, I can attempt to implement the fix first, then the clean up after