From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B2B17633BD for ; Tue, 9 Feb 2021 17:44:40 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A324884D4 for ; Tue, 9 Feb 2021 17:44:10 +0100 (CET) Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 4AE7A84BA for ; Tue, 9 Feb 2021 17:44:06 +0100 (CET) Received: by mail-wm1-x329.google.com with SMTP id t142so3847885wmt.1 for ; Tue, 09 Feb 2021 08:44:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=odiso-com.20150623.gappssmtp.com; s=20150623; h=message-id:subject:from:to:date:in-reply-to:references:user-agent :mime-version; bh=GLFEdJ7PufyboN65DUcIDHPgn7ET+rBfnMYp/q7gkjg=; b=wMos+xXWHwdjmqa3ne2skLDZcQnb0fQxB7pn40575L6QkLWXaA3mXUdusfXZ0jNJCH gvrSphUeRfaUe+eI7OVkQ4FDdSn/n7WNjGkjd8iYcvCGb0TF/scqiFK0nD9QI9nvSBno BDmm9EqtiFBGndJUtLx9FeZtbuHHtcnUm6GluOKbDAfZTksWcu3dbpVfCOATZIl1JLlp 9f8AjkgcfwbaPuYCR3PWyJVzRHfPv9eF6bjBlXeowqtTJ0Wd4aqEdqHGI11JeW9t0QYJ hYFlBWmLt+mnTz5aKGQ3zn6lCK4EJneq8aSSTRT3aq+8WPOdv90h334Io4VCKOmB/mfn gV9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version; bh=GLFEdJ7PufyboN65DUcIDHPgn7ET+rBfnMYp/q7gkjg=; b=YKvEz+6PT4yadMQJTReb8cU+Fr3D8om/T6V00wIABPmutdbzjR9h41nH27Dc+Np75n anA/EPtACQQXQbUH1Ce6hiaxsQazNsUMUstllKb0PbnQ6xsDhCadfeM+aVbuNSSCxjDJ BIEP61STDtpljlFh096/T6HTI/3ommDCm7CCM4I2FnxJaTIa1plazAgHGngQQEAZyq5H qrp5y4rORIsbIM5b0dZZXp9SBVMCV6upFJieIpeSYyn6T0E8pLp1KlHVgh2d+OT47jXL i8I8QhS0wKPXbVQC/Cdd6v0hbyjGvUXwnoFbpsELhV7sVXzr9Tg/G5eeNwlx5u8ENUmG riOw== X-Gm-Message-State: AOAM530fAHJNS2Iocn+YR874LfLjkTgdV88wyEk+OLrl4E+FvbI3A8Mm jRCzfTbolUnLE4hfG2zWV2bF1Q== X-Google-Smtp-Source: ABdhPJx3s2GnoMBfSzdt8uo80ryoa5iC3jJSDFAMPEJapvUSbkKBRhJH+wIO3utDwOmTDpk+v6nohQ== X-Received: by 2002:a05:600c:1909:: with SMTP id j9mr3131434wmq.42.1612889039997; Tue, 09 Feb 2021 08:43:59 -0800 (PST) Received: from ?IPv6:2a0a:1580:0:1::100c? (ovpn1.odiso.net. [2a0a:1580:2000::3f]) by smtp.gmail.com with ESMTPSA id n10sm37555989wro.39.2021.02.09.08.43.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Feb 2021 08:43:59 -0800 (PST) Message-ID: <55c7dfffe1dabf8a410fd9aad8604ea15e03e367.camel@odiso.com> From: aderumier@odiso.com To: Thomas Lamprecht , Proxmox VE development discussion Date: Tue, 09 Feb 2021 17:43:57 +0100 In-Reply-To: <1c7cbe1d-29e1-ab69-525f-032d1d59e167@proxmox.com> References: <20210207133645.3254164-1-aderumier@odiso.com> <1c7cbe1d-29e1-ab69-525f-032d1d59e167@proxmox.com> User-Agent: Evolution 3.38.3 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.127 Adjusted score from AWL reputation of From: address DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature HTML_MESSAGE 0.001 HTML included in message RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [cgroup.pm] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [pve-devel] applied: [PATCH V2 pve-common] add get_pressure_stat X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Feb 2021 16:44:40 -0000 Hi, Le lundi 08 février 2021 à 16:07 +0100, Thomas Lamprecht a écrit : > On 07.02.21 14:36, Alexandre Derumier wrote: > > Signed-off-by: Alexandre Derumier > > --- > >  src/PVE/CGroup.pm | 42 ++++++++++++++++++++++++++++++++++++++++++ > >  1 file changed, 42 insertions(+) > > > > > > I now actually applied this patch, but followed up with two commits: > > * unify parsing from host and cgroup pressure stats into a common sub >   in ProcFSTools > Great, I was planning to do it after this commit apply. > * return undef for the v1 controller case and the zeroed default $res >   if no path is found (i.e., vm/ct not running) > it shouldn't return v1 , because of undef in: my ($path, $ver) = $self->get_path(undef, 1); (I have done this, because pressure stats are already available in v2 path, even if other cpu,mem,disk accounting stats are still in v1 path) But no problem, better to have a check if v1 could be return. > hope that works for you and I made no dumb error anywhere. > Thanks again !