From: Fiona Ebner <f.ebner@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server v3 4/4] Add support for TDX quote-generation-socket object
Date: Thu, 13 Nov 2025 13:12:45 +0100 [thread overview]
Message-ID: <559ec72a-10ac-4b5d-9b29-6b9dd6bf291a@proxmox.com> (raw)
In-Reply-To: <19402537-42a2-4de2-8a07-2c76c66c0ce2@proxmox.com>
Am 13.11.25 um 12:54 PM schrieb Thomas Lamprecht:
> Am 13.11.25 um 12:35 schrieb Fiona Ebner:
>> Am 28.10.25 um 1:56 PM schrieb Anton Iacobaeus:
>>> + } elsif ($type eq 'vsock') {
>>> + my ($cid, $port) = @{$conf}{ 'vsock-cid', 'vsock-port' };
>>
>> Style nit: our code base uses the following style:
>> $conf->@{qw(vsock-cid vsock-port)};
>
> The main important thing here is IMO using postfix reference notation though.
> As personally, I'm not a huge fan of qw if not needed, I'm certainly fine with
> others using it, but would not promote it over:
>
> $conf->@{'vsock-cid', 'vsock-port'};
Ack
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-11-13 12:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-28 12:54 [pve-devel] [PATCH edk2-firmware/manager/qemu-server v3 0/9] Add support for Intel TDX Anton Iacobaeus
2025-10-28 12:54 ` [pve-devel] [PATCH edk2-firmware v3 1/3] Change name of SEV-related OVMF files Anton Iacobaeus
2025-10-28 12:54 ` [pve-devel] [PATCH edk2-firmware v3 2/3] Add firmware target for TDFV Anton Iacobaeus
2025-10-28 12:54 ` [pve-devel] [PATCH edk2-firmware v3 3/3] Add SCSI in NCCFV for TD guest Anton Iacobaeus
2025-10-28 12:54 ` [pve-devel] [PATCH manager v3 1/2] Add support for Intel TDX Anton Iacobaeus
2025-11-14 10:06 ` [pve-devel] applied: " Fiona Ebner
2025-10-28 12:54 ` [pve-devel] [PATCH manager v3 2/2] Add support for TDX attestation Anton Iacobaeus
2025-10-28 12:54 ` [pve-devel] [PATCH qemu-server v3 1/4] Adapt AMD SEV code for compatibility with other platforms Anton Iacobaeus
2025-10-28 12:54 ` [pve-devel] [PATCH qemu-server v3 2/4] Add check for TDX support Anton Iacobaeus
2025-10-28 12:54 ` [pve-devel] [PATCH qemu-server v3 3/4] Add support for Intel TDX Anton Iacobaeus
2025-10-28 12:54 ` [pve-devel] [PATCH qemu-server v3 4/4] Add support for TDX quote-generation-socket object Anton Iacobaeus
2025-11-13 11:35 ` Fiona Ebner
2025-11-13 11:54 ` Thomas Lamprecht
2025-11-13 12:12 ` Fiona Ebner [this message]
2025-11-14 6:47 ` Anton Iacobaeus
2025-11-14 10:08 ` Fiona Ebner
2025-11-10 15:03 ` [pve-devel] [PATCH edk2-firmware/manager/qemu-server v3 0/9] Add support for Intel TDX Anton Iacobaeus
2025-11-12 13:48 ` Fiona Ebner
2025-11-12 14:48 ` Fiona Ebner
2025-11-13 11:21 ` [pve-devel] partially-applied: " Fiona Ebner
2025-11-14 6:39 ` Anton Iacobaeus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559ec72a-10ac-4b5d-9b29-6b9dd6bf291a@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox