From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id D4A441FF15E for ; Mon, 10 Nov 2025 15:29:29 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7438A17FB3; Mon, 10 Nov 2025 15:30:14 +0100 (CET) Message-ID: <5595ba2c-b804-4b2c-bc5e-18c6141a9555@proxmox.com> Date: Mon, 10 Nov 2025 15:30:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox VE development discussion , Markus Frank References: <20251110114032.125526-1-m.frank@proxmox.com> <20251110114032.125526-3-m.frank@proxmox.com> Content-Language: en-US From: Thomas Lamprecht In-Reply-To: <20251110114032.125526-3-m.frank@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1762784988403 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.024 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH pve-manager v1 2/2] ui: qemu: add Vulkan option in DisplayEdit X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 10.11.25 um 12:40 schrieb Markus Frank: > The 'isVirgl' formula deactivates the Vulkan option if the type is not > 'virtio-gl'. However, it does not reset the option to its default. > Therefore, also add a listener function to reset the Vulkan option. > > Signed-off-by: Markus Frank > --- > www/manager6/qemu/DisplayEdit.js | 42 +++++++++++++++++++++++++++++++- > 1 file changed, 41 insertions(+), 1 deletion(-) > > diff --git a/www/manager6/qemu/DisplayEdit.js b/www/manager6/qemu/DisplayEdit.js > index a2c28ba7..c9a404c4 100644 > --- a/www/manager6/qemu/DisplayEdit.js > +++ b/www/manager6/qemu/DisplayEdit.js > @@ -11,12 +11,30 @@ Ext.define('PVE.qemu.DisplayInputPanel', { > return { vga: ret }; > }, > > + controller: { > + xclass: 'Ext.app.ViewController', > + > + onTypeChange: function (type) { > + let me = this; > + let vm = me.getViewModel(); > + > + if (type.getValue() !== 'virtio-gl') { > + vm.set('vulkan', '__default__'); > + vm.notify(); > + } > + }, > + }, > + > viewModel: { > data: { > type: '__default__', > clipboard: '__default__', > + vulkan: '__default__', > }, > formulas: { > + isVirgl: function (get) { > + return get('type') === 'virtio-gl'; > + }, > matchNonGUIOption: function (get) { > return get('type').match(/^(serial\d|none)$/); > }, > @@ -58,10 +76,32 @@ Ext.define('PVE.qemu.DisplayInputPanel', { > } > return true; > }, > + listeners: { change: 'onTypeChange' }, > bind: { > value: '{type}', > }, > }, > + { > + xtype: 'proxmoxKVComboBox', > + name: 'vulkan', > + deleteEmpty: false, > + fieldLabel: gettext('Vulkan'), > + comboItems: [ > + [ > + '__default__', > + Proxmox.Utils.defaultText + ' (' + Proxmox.Utils.disabledText + ')', > + ], > + ['venus-512', 'Venus (512 MiB memory window)'], > + ['venus-1024', 'Venus (1024 MiB memory window)'], > + ['venus-2048', 'Venus (2048 MiB memory window)'], > + ['venus-4096', 'Venus (4096 MiB memory window)'], > + ['venus-8192', 'Venus (8192 MiB memory window)'], > + ], might be nicer to virtually split the option into two here, i.e. a checkbox for vulkan/venus and a dedicated combobox for the memory window size (or just leave that out for now if it doesn't make a measurable difference anyway. > + bind: { > + value: '{vulkan}', > + disabled: '{!isVirgl}', > + }, > + }, > { > xtype: 'proxmoxintegerfield', > emptyText: Proxmox.Utils.defaultText, > @@ -139,7 +179,7 @@ Ext.define('PVE.qemu.DisplayEdit', { > vmconfig: undefined, > > subject: gettext('Display'), > - width: 350, > + width: 370, > > items: [ > { _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel