From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with UTF8SMTPS id DB55D6ACD1 for ; Wed, 9 Dec 2020 12:23:19 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with UTF8SMTP id D24F9F9AD for ; Wed, 9 Dec 2020 12:23:19 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with UTF8SMTPS id 32466F99C for ; Wed, 9 Dec 2020 12:23:18 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with UTF8SMTP id F39E841883 for ; Wed, 9 Dec 2020 12:23:17 +0100 (CET) To: pve-devel@lists.proxmox.com References: <5FCACA8A02000088000040E7@mail.comsolve.nl> <5FCACA8A02000088000040E7@mail.comsolve.nl> From: Dominik Csapak Message-ID: <54f26d2b-dd9b-4f85-ae83-7c6260c26962@proxmox.com> Date: Wed, 9 Dec 2020 12:23:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:84.0) Gecko/20100101 Thunderbird/84.0 MIME-Version: 1.0 In-Reply-To: <5FCACA8A02000088000040E7@mail.comsolve.nl> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.293 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pve-devel] intro'ing myself X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Dec 2020 11:23:19 -0000 On 12/5/20 12:47 AM, Michael Honkoop wrote: > Hi all, > > First of all nice to meet you, Hi, > > As both a new participant on the list aswell as someone who is trying to step in/up/learn-by-doing i expect my future posts to contain a lot of questions and struggles trying to find a/the structure. > no problem, please ask away. We try to answer question as good as possible, to a reasonable extent. Please make sure to read the developer docs[0], they also contain a link to the build instructions. > My (personal) goal is to enhance skills and produce a working oauth extension, which i have seen was already requested back in 2017. Great you want to tackle that. A good starting point would be probably the 'pve-access-control' package/repository[1] Also it would be nice if you could outline your ideas/use-cases before actually starting to write code, so that we can catch design problems early. > > As PVE as product means multiple disciplines i hope i can be directed in the right direction, as currently i see the code (individually (per-file)), but i am lacking the linkage. i am not sure i understand the question. pve is split into many packages, most of them have their own git repository[2] from those repositories, the packages get built and installed. most code of pve is perl, and in debian you can find the installed perl packages in /usr/share/perl5 and PVE specific code in /usr/share/perl5/PVE > > I mean an extension of a base something i can understand/comprehend, but some stuff like schema seems to be burried deep somewhere and havent figured out how to add stuff. > the jsonschema is a complicated beast ;) but to use it you do not have to look at it directly, better to look at how we use it in many packages there is a PVE/API2/ folder which contains the api endpoint definitions those can serve as examples hope this helps :) kind regards Dominik 0: https://pve.proxmox.com/wiki/Developer_Documentation 1: https://git.proxmox.com/?p=pve-access-control.git;a=summary 2: https://git.proxmox.com