From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <s.reiter@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 1CB4B6381A
 for <pve-devel@lists.proxmox.com>; Wed, 25 Nov 2020 10:36:50 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 0F434173B7
 for <pve-devel@lists.proxmox.com>; Wed, 25 Nov 2020 10:36:20 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [212.186.127.180])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id 9E581173AD
 for <pve-devel@lists.proxmox.com>; Wed, 25 Nov 2020 10:36:19 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 62F3E44074
 for <pve-devel@lists.proxmox.com>; Wed, 25 Nov 2020 10:36:19 +0100 (CET)
To: pve-devel@lists.proxmox.com
References: <20201124154122.22202-1-s.reiter@proxmox.com>
 <20201124154122.22202-4-s.reiter@proxmox.com>
 <1606295317.rggbpdsg10.astroid@nora.none>
From: Stefan Reiter <s.reiter@proxmox.com>
Message-ID: <54c3d679-2c1c-e989-eafb-e91defd51217@proxmox.com>
Date: Wed, 25 Nov 2020 10:36:18 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <1606295317.rggbpdsg10.astroid@nora.none>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.034 Adjusted score from AWL reputation of From: address
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 NICE_REPLY_A           -0.001 Looks like a legit reply (A)
 RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
 http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
 information. [qemuserver.pm]
Subject: Re: [pve-devel] [PATCH v3 qemu-server 3/3] print
 query-proxmox-support result in 'full' status
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Wed, 25 Nov 2020 09:36:50 -0000

On 25/11/2020 10:09, Fabian Grünbichler wrote:
> this needs the following fix-up, else pvestatd spams the log for all not
> runnning VMs:
> 
> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
> index 6966717..0103386 100644
> --- a/PVE/QemuServer.pm
> +++ b/PVE/QemuServer.pm
> @@ -2750,6 +2750,8 @@ sub vmstatus {
> 
>       foreach my $vmid (keys %$list) {
>          next if $opt_vmid && ($vmid ne $opt_vmid);
> +       next if !$res->{$vmid}->{pid}; #not running
> +
>          # we can't use the $qmpclient since it might have already aborted on
>          # 'query-balloon', but this might also fail for older versions...
>          my $qemu_support = eval { mon_cmd($vmid, "query-proxmox-support") };
> 

Ack, that makes sense.