From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 7CB741FF37F for ; Thu, 18 Apr 2024 13:24:23 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 600A41B326; Thu, 18 Apr 2024 13:24:22 +0200 (CEST) Message-ID: <547e0e96-6dea-40bf-bb07-9d5d744ecc5b@proxmox.com> Date: Thu, 18 Apr 2024 13:23:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Fiona Ebner , Proxmox VE development discussion References: <20240416131909.2867605-1-d.csapak@proxmox.com> <20240416131909.2867605-17-d.csapak@proxmox.com> <4843427d-d593-425b-8e28-8f3b7de62612@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <4843427d-d593-425b-8e28-8f3b7de62612@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.014 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager 4/4] ui: enable upload/download buttons for 'import' type storages X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 4/18/24 13:20, Fiona Ebner wrote: > Am 16.04.24 um 15:19 schrieb Dominik Csapak: >> diff --git a/www/manager6/window/UploadToStorage.js b/www/manager6/window/UploadToStorage.js >> index 3c5bba88..79a6e8a6 100644 >> --- a/www/manager6/window/UploadToStorage.js >> +++ b/www/manager6/window/UploadToStorage.js >> @@ -11,6 +11,7 @@ Ext.define('PVE.window.UploadToStorage', { >> acceptedExtensions: { >> iso: ['.img', '.iso'], >> vztmpl: ['.tar.gz', '.tar.xz', '.tar.zst'], >> + 'import': ['ova'], > > Nit: not ordered alphabetically, single quotes not required for key generally you're right about the quotes, but in this case required as 'import' is a reserved name and eslint will complain about unquoted reserved words in that context ;) > > Missing dot before ova > >> }, >> >> cbindData: function(initialConfig) { > > > Apart from that, all pve-manager patches: > > Reviewed-by: Fiona Ebner _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel