From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <f.gruenbichler@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 8B18CC7BC
 for <pve-devel@lists.proxmox.com>; Tue, 29 Nov 2022 19:24:52 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 742B019371
 for <pve-devel@lists.proxmox.com>; Tue, 29 Nov 2022 19:24:52 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS
 for <pve-devel@lists.proxmox.com>; Tue, 29 Nov 2022 19:24:51 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E745544E77
 for <pve-devel@lists.proxmox.com>; Tue, 29 Nov 2022 19:24:50 +0100 (CET)
Date: Tue, 29 Nov 2022 19:24:50 +0100 (CET)
From: =?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= <f.gruenbichler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Message-ID: <538189837.1677.1669746290275@webmail.proxmox.com>
In-Reply-To: <20221129120926.1241594-1-f.gruenbichler@proxmox.com>
References: <20221129120926.1241594-1-f.gruenbichler@proxmox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Priority: 3
Importance: Normal
X-Mailer: Open-Xchange Mailer v7.10.6-Rev30
X-Originating-Client: open-xchange-appsuite
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.135 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH qemu-server] fix #4372: fix vm_resume
 migration callback
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Tue, 29 Nov 2022 18:24:52 -0000

> Fabian Gr=C3=BCnbichler <f.gruenbichler@proxmox.com> hat am 29.11.2022 13=
:09 CET geschrieben:
>=20
> =20
> the fix for the recently introduced requirement of loading the VM config =
while
> migrating was incomplete, since the vmlist node value could already be ou=
t of
> date by the time load_config is called.
>=20
> extend the fallback behaviour even further, by doing the following sequen=
ce:
> - try regular load_config (likely case, rename already fully processed)
> - if it fails, get node from vmlist, and load_config using that
> - it that fails, invalidate the PVE::Cluster cache, retry regular load_co=
nfig
>=20
> Signed-off-by: Fabian Gr=C3=BCnbichler <f.gruenbichler@proxmox.com>

FWIW, I managed to trigger both the fallback and the fallback to the fallba=
ck a few times now with a slightly modified test setup, and both cases (as =
well as the regular code path ;)) work as expected. it triggers quite rarel=
y for me (<1% of migrations, with about a half to a third of those requirin=
g the fallback fallback).