From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 7655C1FF0B7 for ; Fri, 13 Nov 2026 15:10:51 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 37BF121638; Fri, 13 Nov 2026 15:10:46 +0100 (CET) Message-ID: <535fcded-f043-4ebc-85cc-5a059acc8617@proxmox.com> Date: Fri, 13 Nov 2026 15:10:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH pve-guest-common v6 1/3] AbstractConfig: allow passing options to snapshot_rollback To: Jakob Klocker , pve-devel@lists.proxmox.com References: <20261110104601.200493-1-j.klocker@proxmox.com> <20261110104601.200493-2-j.klocker@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20261110104601.200493-2-j.klocker@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794579041427 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.253 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: JVK7JLLD6APIZAAMW2CSRH2JTH2J5PHT X-Message-ID-Hash: JVK7JLLD6APIZAAMW2CSRH2JTH2J5PHT X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 10.11.26 um 11:48 AM schrieb Jakob Klocker: > Thread an optional $opts hashref through snapshot_rollback to > __snapshot_rollback_vm_start, so callers can pass per-rollback options > down to the VM start. Used by qemu-server to let the API override the > guest time sync for a single rollback; other options can be added > without further signature changes. > > Signed-off-by: Jakob Klocker > --- > src/PVE/AbstractConfig.pm | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/src/PVE/AbstractConfig.pm b/src/PVE/AbstractConfig.pm > index 7bcae19..76ea97a 100644 > --- a/src/PVE/AbstractConfig.pm > +++ b/src/PVE/AbstractConfig.pm > @@ -1125,7 +1125,8 @@ my $rollback_remove_replication_snapshots = sub { > > # Rolls back to a given snapshot. > sub snapshot_rollback { > - my ($class, $vmid, $snapname) = @_; > + my ($class, $vmid, $snapname, $opts) = @_; Nit: maybe $vm_start_opts? > + $opts //= {}; > > my $prepare = 1; > > @@ -1197,7 +1198,7 @@ sub snapshot_rollback { > $class->write_config($vmid, $conf); > > if (!$prepare && $snap->{vmstate}) { > - $class->__snapshot_rollback_vm_start($vmid, $snap->{vmstate}, $data); > + $class->__snapshot_rollback_vm_start($vmid, $snap->{vmstate}, $data, $opts); > } > }; >