From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 8D0831FF37F for ; Thu, 18 Apr 2024 10:05:32 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0067A166D6; Thu, 18 Apr 2024 10:05:31 +0200 (CEST) Message-ID: <528aa7b7-57a6-4bb9-b0b6-e3f62e288059@proxmox.com> Date: Thu, 18 Apr 2024 10:05:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Fiona Ebner To: Proxmox VE development discussion , Dominik Csapak References: <20240416131909.2867605-1-d.csapak@proxmox.com> <20240416131909.2867605-9-d.csapak@proxmox.com> Content-Language: en-US In-Reply-To: <20240416131909.2867605-9-d.csapak@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.070 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH storage 8/9] api: allow ova upload/download X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 16.04.24 um 15:19 schrieb Dominik Csapak: > introducing a seperate regex that only contains ova, since s/seperate/separate/ > upload/downloading ovfs does not make sense (since the disks are then > missing). > > Signed-off-by: Dominik Csapak With my single comment below addressed: Reviewed-by: Fiona Ebner > --- > src/PVE/API2/Storage/Status.pm | 14 ++++++++++++-- > src/PVE/Storage.pm | 11 +++++++++++ > 2 files changed, 23 insertions(+), 2 deletions(-) > > diff --git a/src/PVE/API2/Storage/Status.pm b/src/PVE/API2/Storage/Status.pm > index 77ed57c..14d6fe8 100644 > --- a/src/PVE/API2/Storage/Status.pm > +++ b/src/PVE/API2/Storage/Status.pm > @@ -382,7 +382,7 @@ __PACKAGE__->register_method ({ Description above here should be updated to mention OVAs > content => { > description => "Content type.", > type => 'string', format => 'pve-storage-content', > - enum => ['iso', 'vztmpl'], > + enum => ['iso', 'vztmpl', 'import'], > }, > filename => { > description => "The name of the file to create. Caution: This will be normalized!", _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel