From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4A36976ECE for ; Mon, 26 Apr 2021 10:30:12 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 37CF5131B7 for ; Mon, 26 Apr 2021 10:29:42 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 875EA131A9 for ; Mon, 26 Apr 2021 10:29:41 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 48E6642448 for ; Mon, 26 Apr 2021 10:29:41 +0200 (CEST) To: Proxmox VE development discussion , Dominik Csapak References: <20210308134338.31391-1-d.csapak@proxmox.com> From: Stefan Reiter Message-ID: <5207fb64-08c9-3643-c060-fa4bd2d1016e@proxmox.com> Date: Mon, 26 Apr 2021 10:29:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20210308134338.31391-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.022 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [RFC PATCH qemu-server] fix bootdisk_size for new bootorder config scheme X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Apr 2021 08:30:12 -0000 On 3/8/21 2:43 PM, Dominik Csapak wrote: > Previously, we ever only had a single boot *disk*, while possibly > having multiple cdroms/nics in the boot order > > e.g. the config: > > boot: dnc > bootdisk: scsi0 > ide0: media=cdrom,none > scsi0: xxx > net0: ... > > would return the size of scsi0 even though it would first boot > from cdrom/network. > > When editing the bootorder with such a legacy config, we > remove the 'bootdisk' property and replace the legacy notation > with an explicit order, but we only search the first disk > for the size now. > > Restore that behaviour by iterating over all disks in the boot > order property string until we get one that is not a cdrom > and has a size. > > Signed-off-by: Dominik Csapak > --- > i cannot remember if that change was deliberate, but at least one > user ran into that: > > https://forum.proxmox.com/threads/possible-bug-boot-disk-size-shows-as-0b.85454/ > Not intentional, I'm pretty sure I just went with the easy way out back then ;) Reviewed-by: Stefan Reiter