From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 5C2FB9BC5 for ; Mon, 28 Aug 2023 11:20:07 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2E5751B6DE for ; Mon, 28 Aug 2023 11:20:06 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 28 Aug 2023 11:20:05 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 47FE3470B3 for ; Mon, 28 Aug 2023 11:20:05 +0200 (CEST) Message-ID: <51a36c9a-ffa8-4916-b49b-28c6ae13ce14@proxmox.com> Date: Mon, 28 Aug 2023 11:20:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: de-AT, en-US To: Proxmox VE development discussion , Gabriel Goller References: <20230828085134.39413-1-g.goller@proxmox.com> From: Lukas Wagner In-Reply-To: <20230828085134.39413-1-g.goller@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.037 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH common] fix #4162: added `Auto-Submitted` header to email body X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Aug 2023 09:20:07 -0000 On 8/28/23 10:51, Gabriel Goller wrote: > diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm > index 9ffac12..5b5d72c 100644 > --- a/src/PVE/Tools.pm > +++ b/src/PVE/Tools.pm > @@ -1603,6 +1603,7 @@ sub sendmail { > > if (defined($html)) { > print $mail "Content-Type: text/html;\n"; > + print $mail "Auto-Submitted: auto-generated;\n"; > print $mail "\tcharset=\"UTF-8\"\n"; > print $mail "Content-Transfer-Encoding: 8bit\n"; > print $mail "\n"; Just as a side-note: Since my notification patches have been merged a week or two ago, PVE does not actually use PVE::Tools::sendmail any more. Instead, it uses the equivalent Rust implementation of that function from `proxmox_sys::mail::sendmail`. It would make sense to include this change there as well, then we have all products covered (PMG uses the Perl impl, PBS and PVE use the Rust impl). Apart from that: From briefly skimming through the RFC the change makes sense, so consider this: Reviewed-by: Lukas Wagner -- - Lukas