From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <d.csapak@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 55B13F105 for <pve-devel@lists.proxmox.com>; Wed, 14 Dec 2022 10:43:11 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 35A4528362 for <pve-devel@lists.proxmox.com>; Wed, 14 Dec 2022 10:42:41 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Wed, 14 Dec 2022 10:42:40 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B622144330; Wed, 14 Dec 2022 10:42:39 +0100 (CET) Message-ID: <519b67fb-49d0-64e2-c382-983d222cc78c@proxmox.com> Date: Wed, 14 Dec 2022 10:42:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:108.0) Gecko/20100101 Thunderbird/108.0 To: Thomas Lamprecht <t.lamprecht@proxmox.com>, Proxmox VE development discussion <pve-devel@lists.proxmox.com> References: <20221206110635.1885744-1-d.csapak@proxmox.com> <20221206110635.1885744-5-d.csapak@proxmox.com> <d3df76e8-00b4-8429-73d9-9541b0671a8f@proxmox.com> Content-Language: en-US From: Dominik Csapak <d.csapak@proxmox.com> In-Reply-To: <d3df76e8-00b4-8429-73d9-9541b0671a8f@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.064 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] applied: [PATCH manager v2 1/3] ui: realm: sync: don't use realm defaults for remove-vanished X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Wed, 14 Dec 2022 09:43:11 -0000 On 12/13/22 15:15, Thomas Lamprecht wrote: > Am 06/12/2022 um 12:06 schrieb Dominik Csapak: >> if we don't manually set it to the empty string, it will use the >> realm default, which might be unexpected. this way, the sync always >> does what the user saw in the sync window. >> >> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com> >> --- >> www/manager6/dc/SyncWindow.js | 2 ++ >> 1 file changed, 2 insertions(+) >> >> > > applied this one already with fixed up commit message, thanks! seems i forgot to mention here in the patch that this requires the 1/2 of access-control to work, not a problem if we apply that one too and bump accordingly before bumping pve-manager