From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id D8EC81FF189 for <inbox@lore.proxmox.com>; Fri, 4 Apr 2025 14:22:47 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B37D31E24E; Fri, 4 Apr 2025 14:22:35 +0200 (CEST) Message-ID: <516fc86b-5cd2-46f4-90a5-8f6e981f8063@proxmox.com> Date: Fri, 4 Apr 2025 14:22:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Markus Frank <m.frank@proxmox.com> References: <20250403103442.136958-1-m.frank@proxmox.com> Content-Language: en-US From: Daniel Kral <d.kral@proxmox.com> In-Reply-To: <20250403103442.136958-1-m.frank@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.011 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH cluster/guest-common/docs/qemu-server/manager v15 0/12] virtiofs X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> On 4/3/25 12:34, Markus Frank wrote: > Virtio-fs is a shared file system that enables sharing a directory > between host and guest VMs. It takes advantage of the locality of > virtual machines and the hypervisor to get a higher throughput than > the 9p remote file system protocol. > > build-order: > 1. cluster > 2. guest-common > 3. docs > 4. qemu-server > 5. manager > > I did not get virtiofsd to run with run_command without creating > zombie processes after stutdown. So I replaced run_command with exec > for now. Maybe someone can find out why this happens. > > changes in v15: > * removed announce-submounts option altogether and always set it for > virtiofsd. > * added die if both memory hotplug and virtiofs are enabled > * added fstab entry example in the docs > * assert_valid_map_list: only run assert_valid for the mappings on the > current node > * see individual patches Gave this another look and spin with the same setup as yesterday (single node and the three mentioned Debian/Fedora/Win11 VMs) and a 3 node test cluster to also test the remaining parts in a cluster setting with migration. === Migration tests === Tested that offline migration and live migration is blocked correctly, if the resource is not available on another node, i.e. whether there is a dir mapping on another node. If I try to live migrate a VM from one node to another, where the target does not have a dir mapping defined, I get the following precondition errors in the WebGUI: - Can't migrate VM with local resources: virtiofs - Can't migrate running VM with mapped resources: virtiofs0, virtiofs1 - Mapped Resources (virtiofs1) not available on selected target And on the CLI: - can't migrate VM which uses local devices: virtiofs If I try to migrate a VM from one node to another, where the target does not have a dir mapping defined, I get the following precondition errors in the WebGUI: - Mapped Resources (virtiofs1) not available on selected target And on the CLI: - can't migrate to 'node2': missing mapped devices virtiofs1 === Config tests === Otherwise, I did the same tests with xattr / POSIX ACLs as before and this worked just as before. Also the existence of the dir mapping path on the current node is asserted correctly, but in a multi-node setting this could still be improved, see my comments inline. Otherwise, there were some undefined variables warnings and some warnings that could be improved, I also noted them in my comments inline. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel