From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 69EC3859F2 for <pve-devel@lists.proxmox.com>; Mon, 20 Dec 2021 20:25:51 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 56189218BB for <pve-devel@lists.proxmox.com>; Mon, 20 Dec 2021 20:25:21 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id DB5A9218AD for <pve-devel@lists.proxmox.com>; Mon, 20 Dec 2021 20:25:20 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id AD03444F36 for <pve-devel@lists.proxmox.com>; Mon, 20 Dec 2021 20:25:20 +0100 (CET) Message-ID: <5158cee6-fe18-fc0c-cd7d-b300586d0aae@proxmox.com> Date: Mon, 20 Dec 2021 20:25:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:96.0) Gecko/20100101 Thunderbird/96.0 Content-Language: en-GB To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Aaron Lauterer <a.lauterer@proxmox.com> References: <20211220153839.537253-1-a.lauterer@proxmox.com> <20211220153839.537253-2-a.lauterer@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> In-Reply-To: <20211220153839.537253-2-a.lauterer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.875 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -3.608 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH flutter_frontend 2/2] remove unused drawables for android splash screen X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Mon, 20 Dec 2021 19:25:51 -0000 On 20/12/2021 16:38, Aaron Lauterer wrote: > Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com> > --- > .../src/main/res/drawable/launch_background.xml | 11 ----------- > .../drawable/proxmox_logo_white_orange_250.png | Bin 10537 -> 0 bytes > .../drawable/proxmox_logo_white_orange_800.png | Bin 17037 -> 0 bytes > 3 files changed, 11 deletions(-) > delete mode 100644 android/app/src/main/res/drawable/launch_background.xml above is avoided by just keeping the there in the first place > delete mode 100644 android/app/src/main/res/drawable/proxmox_logo_white_orange_250.png > delete mode 100644 android/app/src/main/res/drawable/proxmox_logo_white_orange_800.png > and deleting those isn't really a benefit, git will still track it as part of the repos history, so we'd not really safe space there and if one requires those in the future again there's a chance that they overlook that there's one already hidden in the git history and readds it, actually increasing space usage, so as long as they do not actually hurt us lets just keep them..