From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id C8C8B1FF15F for ; Mon, 18 Nov 2024 10:22:51 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 95DAEB225; Mon, 18 Nov 2024 10:22:55 +0100 (CET) Message-ID: <5120d3d1-4cab-4505-a13b-9ec4aebbebc9@proxmox.com> Date: Mon, 18 Nov 2024 10:22:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Thomas Lamprecht , Proxmox VE development discussion References: <20241115120937.169342-1-s.hanreich@proxmox.com> <20241115120937.169342-5-s.hanreich@proxmox.com> <067c607a-d1da-4abb-b699-6e2a26ff68cd@proxmox.com> Content-Language: en-US From: Stefan Hanreich In-Reply-To: <067c607a-d1da-4abb-b699-6e2a26ff68cd@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.658 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH pve-firewall v4 4/9] add support for loading sdn firewall configuration X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: Wolfgang Bumiller Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 11/17/24 15:57, Thomas Lamprecht wrote: >> diff --git a/src/PVE/Service/pve_firewall.pm b/src/PVE/Service/pve_firewall.pm >> index 65cb2b8..02b507a 100755 >> --- a/src/PVE/Service/pve_firewall.pm >> +++ b/src/PVE/Service/pve_firewall.pm >> @@ -158,7 +158,7 @@ __PACKAGE__->register_method ({ >> >> PVE::Firewall::set_verbose(1); # show syntax errors >> >> - my $cluster_conf = PVE::Firewall::load_clusterfw_conf(undef); >> + my $cluster_conf = PVE::Firewall::load_clusterfw_conf(); > > just to be sure, above and below does not change anything, or? yes. if the first parameter (= filename) is undef, then it loads the config from the default path. I'll look into incorporating the rest of your suggestions - thanks! _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel