From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 729D91FF179 for ; Wed, 1 Oct 2025 13:17:39 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3EF6D1DE89; Wed, 1 Oct 2025 13:17:45 +0200 (CEST) Message-ID: <50ef5f3c-e161-4826-b2b6-f1a6209d2377@proxmox.com> Date: Wed, 1 Oct 2025 13:17:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Thomas Lamprecht , Proxmox VE development discussion References: <20251001093750.51078-1-f.ebner@proxmox.com> <20251001093750.51078-4-f.ebner@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1759317440266 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.021 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH common 3/3] upid: fix calls to decode function X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 01.10.25 um 12:34 PM schrieb Thomas Lamprecht: > Am 01.10.25 um 11:38 schrieb Fiona Ebner: >> The decode function has a signature and always requires two arguments. >> Otherwise, there will be errors like: >>> Too few arguments for subroutine 'PVE::UPID::decode' >>> (got 1; expected 2) at /usr/share/perl5/PVE/UPID.pm line 60. > > I replaced this with just adapting the signature to have a default > value for $noerr defined there, which avoids having to update > call sides; as thanks to use v5.36 we can do > > sub decode($upid, $noerr = 0) { > ... > > > I also added a basic test harness to finally have some coverage > here. Oh, good to know that that's possible too :) _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel