From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 24E971FF168 for ; Tue, 12 Nov 2024 10:29:10 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7E6941C030; Tue, 12 Nov 2024 10:29:10 +0100 (CET) Date: Tue, 12 Nov 2024 10:28:37 +0100 (CET) From: Timothy Nicholson To: Proxmox VE development discussion Message-ID: <504516130.2204.1731403717537@webmail.proxmox.com> In-Reply-To: <907f5afc-f581-4e9b-892e-d5d0f5f464f2@proxmox.com> References: <20241111113519.118949-1-t.nicholson@proxmox.com> <907f5afc-f581-4e9b-892e-d5d0f5f464f2@proxmox.com> MIME-Version: 1.0 X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.6-Rev69 X-Originating-Client: open-xchange-appsuite X-SPAM-LEVEL: Spam detection results: 0 AWL 0.905 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager] fix #5847: ui: gettextize several strings in ui X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" > Dominik Csapak hat am 12.11.2024 10:16 CET geschrieben: > > > one comment inline > > On 11/11/24 12:35, Timothy Nicholson wrote: > > Several strings that should probably also be translated now use > > the gettext function to be translated. > > > > Signed-off-by: Timothy Nicholson > > --- > > [0]: https://bugzilla.proxmox.com/show_bug.cgi?id=5847 > > > > www/manager6/Workspace.js | 2 +- > > www/manager6/ceph/OSD.js | 6 +++--- > > www/manager6/ceph/OSDDetails.js | 2 +- > > www/manager6/form/VMCPUFlagSelector.js | 24 ++++++++++++------------ > > www/manager6/qemu/ProcessorEdit.js | 2 +- > > www/manager6/window/Settings.js | 6 +++--- > > 6 files changed, 21 insertions(+), 21 deletions(-) > > > > diff --git a/www/manager6/Workspace.js b/www/manager6/Workspace.js > > index 52c66108..56dde151 100644 > > --- a/www/manager6/Workspace.js > > +++ b/www/manager6/Workspace.js > > @@ -388,7 +388,7 @@ Ext.define('PVE.StdWorkspace', { > > }, > > }, > > { > > - text: 'TFA', > > + text: gettext('TFA'), > > is it a good idea to translate this? it's mostly a technical term (which we generally don't > translate), but i'd be swayed if there is an actual example where a language want > to have that translated... Some languages already translate TFA as 2FA (e.g. German) and TFA is already translated in other parts of the UI. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel