From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id DF6001FF183 for ; Wed, 16 Jul 2025 09:42:36 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D34819467; Wed, 16 Jul 2025 09:43:41 +0200 (CEST) Message-ID: <503e7b2f-4f3c-42b0-bf2f-32dc723b57e4@proxmox.com> Date: Wed, 16 Jul 2025 09:43:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Hannes Duerr References: <20250711095206.30852-1-h.duerr@proxmox.com> Content-Language: en-US From: Friedrich Weber In-Reply-To: <20250711095206.30852-1-h.duerr@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.011 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_MSPIKE_H2 0.001 Average reputation (+2) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH pve-network 1/2] dhcp: make plugin types query from Dhcp.pm possible X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 11/07/2025 11:52, Hannes Duerr wrote: > At the moment it is possible to query the Dhcp plugin types from the > `use PVE::Network::SDN::Dhcp::Plugin` without importing > `PVE::Network::SDN::Dhcp`. In consequence the section config is not > created although one would have been expected it to be created. > > Importing `use pve::network::sdn::Dhcp` would solve the issue, but since > this is not a nice pattern and in order to avoid such problems in the > future, we are now making it possible to query the plugin type from > DHCP. If you then import DHCP, the section config will be built > correctly. > > The problem was noticed/introduced after the ordering of the two imports > `use PVE::Network::SDN::Vnets` and `use PVE::Network::SDN::Vnets` were > swapped in pve-bridge [0], resulting in the error: > > file /etc/pve/sdn/zones.cfg line 2 (section 'simple') - unable to parse value of 'dhcp': value 'dnsmasq' does not have a value in the enumeration '' > > The Zones Section Config no longer returned correct values for dhcp > because the Section Config was not yet built correctly at that time. > Swapping the entries back also solves the issue, because Vnets.pm is > importing `PVE::Network::SDN::Dhcp`, but that is also not really a nice > solution > > [0] https://lore.proxmox.com/pve-devel/20250625155751.268047-6-f.ebner@proxmox.com/ > > Signed-off-by: Hannes Duerr > --- Tested that - currently, on trixie, a VM in a Simple zone with automatic DHCP doesn't get a DHCP lease, and the 'dnsmasq does not have a value in the enumeration' warning appears in the qmstart task log (but is not marked as a task log warning) - after applying these two patches, the VM gets a DHCP lease again Though I haven't really tested much other SDN functionality, consider this Tested-by: Friedrich Weber _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel