From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 748601FF136 for ; Mon, 23 Mar 2026 17:49:34 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 48D6432938; Mon, 23 Mar 2026 17:49:51 +0100 (CET) Date: Mon, 23 Mar 2026 17:49:15 +0100 From: Arthur Bied-Charreton To: Lukas Wagner Subject: Re: [PATCH proxmox-widget-toolkit 2/2] notifications: Add opt-in OAuth2 support for SMTP targets Message-ID: <4yvoj7d5dckznvkjsmtjvoegcqxojnuzu5hbdkqgg5uqqbqddz@fkt6hx4xi4iv> References: <20260213160415.609868-1-a.bied-charreton@proxmox.com> <20260213160415.609868-11-a.bied-charreton@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774284510610 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.825 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 5N72XKHVSGEAZ5GOIGBH7YI7POUJEE22 X-Message-ID-Hash: 5N72XKHVSGEAZ5GOIGBH7YI7POUJEE22 X-MailFrom: a.bied-charreton@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, Mar 23, 2026 at 01:26:25PM +0100, Lukas Wagner wrote: > On Fri Feb 13, 2026 at 5:04 PM CET, Arthur Bied-Charreton wrote: > > Add Google & Microsoft OAuth2 authentication methods to SMTP endpoint > > config. > > The enableOAuth2 pmxSmtpEditPanel config flag allows consumers to opt > > into the new feature, so it can be gradually introduced into services. > > > > When disabled, no changes are visible from the UI, and only 'None' and > > 'Username/Password' are shown as > > authentication methods. The flag is passed from the schema config, as it > > is done for defaultMailAuthor. > > > > Signed-off-by: Arthur Bied-Charreton > > Some notes: > > - same as the other patch, this seems to be missing a `make tidy` > ACK this and the other patch where you mentioned it, thanks! > - when adding a new endpoint, after successful authorization, it would > be nice to get visual feedback in the dialog. Maybe something like a > green checkmark and "Authorized" in the UI next to the button? > Will do, sounds like a nice addition > - when editing an existing OAUTH SMTP endpoint, the "Client Secret" > field is marked invalid because it does not contain any text, also > making it impossible to change anything else in this endpoint. > This should handled similarly to how we handle the regular password > field: Only require a value if isCreate is true, and use a > "Unchanged" empty text otherwise. ACK, will do > > - Not 100% sure, but from my understanding the term "Authorize" would > be more fitting then "Authenticate" > You are 100% correct, thanks for catching that