From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id 98A931FF140
	for <inbox@lore.proxmox.com>; Fri, 27 Mar 2026 02:12:50 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 81E3F1F6B7;
	Fri, 27 Mar 2026 02:13:13 +0100 (CET)
Message-ID: <4fb7df53-22cd-4bd5-a586-3b8a7a3ed32c@proxmox.com>
Date: Fri, 27 Mar 2026 02:12:39 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird Beta
Subject: Re: [PATCH qemu-server v2 1/4] agent: add should_fs_freeze helper
To: Fiona Ebner <f.ebner@proxmox.com>, pve-devel@lists.proxmox.com
References: <20260325213415.3861690-1-t.lamprecht@proxmox.com>
 <20260325213415.3861690-2-t.lamprecht@proxmox.com>
 <16fb9fa8-a0a3-4ccb-ab8c-800c23ac2334@proxmox.com>
Content-Language: en-US
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
In-Reply-To: <16fb9fa8-a0a3-4ccb-ab8c-800c23ac2334@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1774573910690
X-SPAM-LEVEL: Spam detection results:  0
	AWL                    -0.009 Adjusted score from AWL reputation of From:
 address
	BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: NHS27JJKGSDWIZOM42USNEWZY2C4QIKJ
X-Message-ID-Hash: NHS27JJKGSDWIZOM42USNEWZY2C4QIKJ
X-MailFrom: t.lamprecht@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

Am 26.03.26 um 13:54 schrieb Fiona Ebner:
> I feel like we should either rename the existing guest_fs{freeze,thaw}()
> functions or this one for consistency ('fs_freeze' versus 'fsfreeze').

Agree, that would be nicer to read too besides consistency.