From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B8AB3919AB for ; Thu, 29 Sep 2022 14:39:08 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9C46F411B for ; Thu, 29 Sep 2022 14:39:08 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 29 Sep 2022 14:39:08 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E45694464D for ; Thu, 29 Sep 2022 14:39:07 +0200 (CEST) Message-ID: <4fa326fc-8bfb-efbe-3b2d-fd03f63278a3@proxmox.com> Date: Thu, 29 Sep 2022 14:39:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:106.0) Gecko/20100101 Thunderbird/106.0 Content-Language: en-GB To: Proxmox VE development discussion , =?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= References: <20220928125059.1139296-1-f.gruenbichler@proxmox.com> <20220928125059.1139296-14-f.gruenbichler@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20220928125059.1139296-14-f.gruenbichler@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL -0.029 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [storage.pm, pvesm.pm] Subject: [pve-devel] applied: [PATCH v6 storage 1/1] (remote) export: check and untaint format X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Sep 2022 12:39:08 -0000 Am 28/09/2022 um 14:50 schrieb Fabian Gr=C3=BCnbichler: > this format comes from the remote cluster, so it might not be supported= > on the source side - checking whether it's known (as additional > safeguard) and untainting (to avoid open3 failure) is required. >=20 > Signed-off-by: Fabian Gr=C3=BCnbichler > --- >=20 > Notes: > v6: new >=20 > PVE/CLI/pvesm.pm | 6 ++---- > PVE/Storage.pm | 9 +++++++++ > 2 files changed, 11 insertions(+), 4 deletions(-) >=20 > applied, with a small code style fixup (`($foo->@*)[0]` vs `$foo->[0]`) s= quashed in, thanks!