From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 59AAEC25A4 for ; Tue, 23 Jan 2024 11:01:31 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3F11F35E55 for ; Tue, 23 Jan 2024 11:01:31 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 23 Jan 2024 11:01:30 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4504649244 for ; Tue, 23 Jan 2024 11:01:30 +0100 (CET) Message-ID: <4f959cf9-5068-4c14-aaf6-885f9cbf982a@proxmox.com> Date: Tue, 23 Jan 2024 11:01:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Proxmox VE development discussion References: <20240118111147.131727-1-f.weber@proxmox.com> From: Friedrich Weber In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.097 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [lvmplugin.pm] Subject: Re: [pve-devel] [PATCH v2 storage] lvm: improve warning in case vgs output contains unexpected lines X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Jan 2024 10:01:31 -0000 On 19/01/2024 12:31, Fiona Ebner wrote: > Am 19.01.24 um 11:59 schrieb Fiona Ebner: >> Am 18.01.24 um 12:11 schrieb Friedrich Weber: >>> diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm >>> index 4b951e7..5377823 100644 >>> --- a/src/PVE/Storage/LVMPlugin.pm >>> +++ b/src/PVE/Storage/LVMPlugin.pm >>> @@ -130,6 +130,11 @@ sub lvm_vgs { >>> >>> my ($name, $size, $free, $lvcount, $pvname, $pvsize, $pvfree) = split (':', $line); >>> >>> + if (!defined($size) || !defined($free) || !defined($lvcount)) { >>> + warn "unexpected output from vgs: $line\n"; >>> + return; >>> + } >>> + >> >> Nit: maybe quote 'vgs' and/or say "command 'vgs'"? Sounds good! >> Please use log_warn() from PVE::RESTEnvironment for new warnings, so >> they also show up in task logs. > > Sorry, I mean "show up more visibly", because they count towards the > warning count shown in the task result. Thanks, wasn't aware of this benefit of `log_warn`. Will send a v3 with the two changes.