From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C0E4A64878 for ; Fri, 28 Jan 2022 12:22:13 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AEFB02DFC8 for ; Fri, 28 Jan 2022 12:21:43 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id CA3152DFBD for ; Fri, 28 Jan 2022 12:21:42 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A249346CF8; Fri, 28 Jan 2022 12:21:42 +0100 (CET) Message-ID: <4f895980-02c0-0b89-90d3-8cfec88c6264@proxmox.com> Date: Fri, 28 Jan 2022 12:21:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Content-Language: en-US To: Alwin Antreich , Thomas Lamprecht , Proxmox VE development discussion References: <01a32358-484e-1c8b-61c9-e03b9df5dbae@proxmox.com> <51d6f7da-3163-2fe4-05a3-dc63226088e0@proxmox.com> <1ae1d772-c466-5694-cf77-4018aedddafc@proxmox.com> <20220126160734.2868618-1-a.lauterer@proxmox.com> <3dbb90bb8bfec2db7a08965c0301480f@antreich.com> <00b53f8566061be26bdf770332245ea9@antreich.com> <0e3081d0-3d09-798a-e4d2-209db646ae75@proxmox.com> <29676a1a69dbb2be089f03d837f4f399@antreich.com> From: Aaron Lauterer In-Reply-To: <29676a1a69dbb2be089f03d837f4f399@antreich.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.005 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [croit.io, proxmox.com] Subject: Re: [pve-devel] [PATCH storage] rbd: add support for erasure coded ec pools X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Jan 2022 11:22:13 -0000 On 1/28/22 11:54, Alwin Antreich wrote: > January 28, 2022 10:50 AM, "Aaron Lauterer" wrote: > >> What exactly do you mean? How to add custom config options for external cluster >> (/etc/pve/priv/ceph/.conf) and locally in the /etc/pve/ceph.conf AKA /etc/ceph/ceph.conf? > Oh. I was thinking, if the /etc/pve/priv/ceph/.conf is not favored, then I could document the usage of client settings in the /etc/pve/ceph.conf. Well, it is there for external clusters, just not really documented atm. For a hyperconverged cluster (no monhost line in the storage config, line 185 [0]) it is ignored [0]. If it is configured, it is then added as `-c` to the RBD command, therefore the default ceph config is ignored IIUC [1]. [0] https://git.proxmox.com/?p=pve-storage.git;a=blob;f=PVE/CephConfig.pm;h=c388f025b409c660913c082763765dda0fba2c6c;hb=HEAD#l192 [1] https://git.proxmox.com/?p=pve-storage.git;a=blob;f=PVE/Storage/RBDPlugin.pm;h=2607d259d1ab20f0f430ee7d0083bcd77289c2ac;hb=HEAD#l48 > >> >> Sure, AFAICS the custom .conf has been added in 2016 [0]. I did a quick search in the >> admin guide and did not find anything about it. >> >> [0] https://git.proxmox.com/?p=pve-storage.git;a=commit;h=1341722 > Then I'll prepare some docs patch. :) > >> Right now, I am only working out the EC pools (data-pool) parameter. Having the current >> possibilities documented is surely a good idea. >> >> Out of curiosity, do you have to use the custom configs often? > So far it might have been a hand full of times. (that I recall) > Currently we have a small how-to on the website with the /etc/ceph.conf.[0] I want to update this guide as well. I took a quick look. JFYI the keyring (and cephfs secret) don't need to be placed manually anymore with recent versions as the pvesm command can take a path to those files and will place it at the correct location [2]. GUI patches for that are currently reviewed. Once this patch is applied, your guide will hopefully become a bit shorter. Or longer to cover both cases ;) Have a great weekend! [2] https://git.proxmox.com/?p=pve-storage.git;a=commit;h=22b68016f791958baf7dd982cb92d2306f0e1574 > > Cheers, > Alwin > > [0] https://croit.io/docs/master/hypervisors/proxmox >