From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A8C57933FB for ; Mon, 5 Feb 2024 12:40:23 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 88E8E15D0B for ; Mon, 5 Feb 2024 12:39:53 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 5 Feb 2024 12:39:52 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D485644307 for ; Mon, 5 Feb 2024 12:39:51 +0100 (CET) Message-ID: <4e762285-2455-4d7f-986d-62b4d42dcf82@proxmox.com> Date: Mon, 5 Feb 2024 12:39:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Thomas Lamprecht , Proxmox VE development discussion References: <20240125094030.72875-1-f.ebner@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.073 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] applied: [PATCH v2 qemu] add patches to work around stuck guest IO with iothread and VirtIO block/SCSI X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2024 11:40:23 -0000 Am 02.02.24 um 19:42 schrieb Thomas Lamprecht: > > basically applied this, thanks. > > Basically, as I went for the v2 [0], as the series file needed some adaption > due to recent v8.1.5 patch I just made a new commit but kept your message and > added an Originally-by Trailer, hope that's all right with you. > Yes, sure. Wanted to send a new version anyways :) While the diff to v1 is pretty small, I did a quick test again and found no obvious issue, while it still fixes my reproducer. > [0]: https://lore.kernel.org/qemu-devel/20240202153158.788922-1-hreitz@redhat.com/ > But still only the first two patches, the clean-up did not applied at 8.1.5 > and I did not bother checking that out closely. Yes, there were some changes in the meantime and while a backport might be removing the event_notifier_set() call from virtio_blk_data_plane_start(), with the current code, there also is a smp_wmb() and aio_context_acquire(s->ctx) in between event_notifier_set() and virtio_queue_aio_attach_host_notifier(), so not sure if that's okay in all scenarios. I don't think the backport is necessary, because setting the event notifier twice will just kick the virt queue twice.