From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 92246941FE for ; Thu, 23 Feb 2023 11:20:55 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6C11B233FC for ; Thu, 23 Feb 2023 11:20:25 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 23 Feb 2023 11:20:24 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 781DB482DE for ; Thu, 23 Feb 2023 11:20:24 +0100 (CET) Message-ID: <4d797911-99ed-9806-b6a7-6b049e86807f@proxmox.com> Date: Thu, 23 Feb 2023 11:20:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 To: pve-devel@lists.proxmox.com References: <20230223101441.17619-1-n.ullreich@proxmox.com> Content-Language: en-US From: Noel Ullreich In-Reply-To: <20230223101441.17619-1-n.ullreich@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.160 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.102 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pve-devel] [PATCH proxmox-widget-toolkit] Fix Unnecessarry parentheses error X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Feb 2023 10:20:55 -0000 Sorry, didn't see that a patch was sent for this on the 15th already: https://lists.proxmox.com/pipermail/pve-devel/2023-February/055798.html. This patch can be ignored. On 23-02-2023 11:14, Noel Ullreich wrote: > As is, the code will throw an `ERR : line 162 col 22: no-extra-parens - > Unnecessary parentheses around expression. (*)`. Since `data.normalized` > will be evaluated as false if it is null anyway, adding a nullish operator > `??` is not needed. > > Signed-off-by: Noel Ullreich > --- > src/window/DiskSmart.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/window/DiskSmart.js b/src/window/DiskSmart.js > index b538ea1..834f065 100644 > --- a/src/window/DiskSmart.js > +++ b/src/window/DiskSmart.js > @@ -159,7 +159,7 @@ Ext.define('Proxmox.window.DiskSmart', { > { > name: 'real-value', > // FIXME remove with next major release (PBS 3.0) > - calculate: data => (data.normalized ?? false) ? data.raw : data.value, > + calculate: data => data.normalized ? data.raw : data.value, > }, > { > name: 'real-normalized',