From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 9F5D71FF15E for <inbox@lore.proxmox.com>; Fri, 20 Sep 2024 09:32:04 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2E86E3178C; Fri, 20 Sep 2024 09:32:12 +0200 (CEST) Message-ID: <4d149eb4-a7ef-4662-93b8-0181c9080a02@proxmox.com> Date: Fri, 20 Sep 2024 09:32:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Esi Y <esiy0676+proxmox@gmail.com>, Proxmox VE development discussion <pve-devel@lists.proxmox.com> References: <20240919095202.1375181-1-d.csapak@proxmox.com> <21f250b8-a59c-426d-96de-11606cbb0e42@proxmox.com> <c6a05311-215e-4a5a-82ac-a1032fb331ec@proxmox.com> <d5b69768-acc4-45f7-bd3b-7cfe26cb261a@proxmox.com> <mailman.23.1726805127.332.pve-devel@lists.proxmox.com> <CABtLnHoQFAUN0KcahbMF6hoX=WTfL8bHL0St77gQMSaojVGhBA@mail.gmail.com> Content-Language: en-US From: Dominik Csapak <d.csapak@proxmox.com> In-Reply-To: <CABtLnHoQFAUN0KcahbMF6hoX=WTfL8bHL0St77gQMSaojVGhBA@mail.gmail.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [RFC PATCH pve-cluster] fix #5728: pmxcfs: allow bigger writes than 4k for fuse X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> Hi, I'm replying to this mail, but it's more of a general answer. While we always appreciate efforts to improve our software/code/stack, maybe you're recent attempts are not as constructive as they could be. Of course we can try to optimize every part of our code to be as efficient and good as possible all the time, but we don't do that because: * we don't have unlimited developer time * having stable behavior can be more important than squeezing out the most performance So we often change working existing code (especially the most important parts like the pmxcfs) only if either: * there is a bug * the change is pretty obviously better * we encounter an actual limit/problem that is important (e.g. affects many people in a noticeable way) * there is a big demand from users/customers (note that this list is not exhaustive, and even if a change fulfills one of these, we might not pursue it, depending on the specific circumstances) Instead of just calling out weird/unfamiliar behavior/code/design, I'd recommend going a different route, for example explaining why a problem has a big impact on many people, best while providing actual code and/or concrete solutions. (It's always easier to criticize other people's work than actually doing it better) I cannot and don't want to stop you from looking into our code base and find flaws/issues/etc. but maybe using a different approach to communicate those, would yield better results than what you have done until now. Please don't take this answer the wrong way, I just want to improve communication, so we can improve our software in a better and more efficient way. best regards Dominik _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel