From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 8A9FF1FF13B for ; Wed, 11 Feb 2026 12:41:31 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BDB471A3E0; Wed, 11 Feb 2026 12:42:15 +0100 (CET) Message-ID: <4cd8f63e-d851-4ea2-87a7-5d7510e63b05@proxmox.com> Date: Wed, 11 Feb 2026 12:41:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH qemu 1/2] generate and ship static list of CPU models To: Thomas Lamprecht , pve-devel@lists.proxmox.com References: <20260210135417.184127-1-f.ebner@proxmox.com> <20260210135417.184127-2-f.ebner@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1770810014392 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: S4IRZ2LIPEW6C3CGMDN3IHO4ES2SPXLG X-Message-ID-Hash: S4IRZ2LIPEW6C3CGMDN3IHO4ES2SPXLG X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 11.02.26 um 11:32 AM schrieb Thomas Lamprecht: > Am 10.02.26 um 14:53 schrieb Fiona Ebner: >> Fail the build when the list changes, so that new models can be >> picked up selectively and other changes that might require adaptations >> are not missed. > > thanks, any objection in storing this as pretty-formatted json? > As then the default line-based git diff is making comparisons simpler, > as while word-diff is great, it has it's limits IMO. No objection, I was considering it too after sending and seeing the very long line in the patch. But wasn't sure :) > No need for a v2 in any case, as that change is easy enough to squash in. Thanks! > btw. starting to wonder if we should produce an extra architecture "all" > packages for such files, could reduce churn on selective uploads; but I'd > figure that the current rate of change will slow down a bit soon. One file for recognized aarch64 CPU flags might still come along in the context of the custom CPU model edit API/UI. Otherwise, changes to those files usually come together with switching to a new upstream version.