From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C4A129830D for ; Sat, 22 Apr 2023 09:38:57 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9D5D121E82 for ; Sat, 22 Apr 2023 09:38:27 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Sat, 22 Apr 2023 09:38:27 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D81AF41EAA for ; Sat, 22 Apr 2023 09:38:26 +0200 (CEST) Message-ID: <4cd6772a-1559-b4ec-1c69-2b4952e80432@proxmox.com> Date: Sat, 22 Apr 2023 09:38:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-GB To: Proxmox VE development discussion , Dominik Csapak References: <20230420080616.836255-1-d.csapak@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20230420080616.836255-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.088 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH manager 1/3] fix #4678: ui: don't sort storage backup content by vmid by default X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Apr 2023 07:38:57 -0000 On 20/04/2023 10:06, Dominik Csapak wrote: > instead, add the vmid as extra column, so that the user can still sort > by vmid if they wish to > missing Reported-by tag, would potentially also split this > Signed-off-by: Dominik Csapak > --- > www/manager6/storage/BackupView.js | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/www/manager6/storage/BackupView.js b/www/manager6/storage/BackupView.js > index fbdf573d3..9ad1a4915 100644 > --- a/www/manager6/storage/BackupView.js > +++ b/www/manager6/storage/BackupView.js > @@ -220,16 +220,20 @@ Ext.define('PVE.storage.BackupView', { > }, > }, > }; > + } else { > + me.extraColumns = {}; this is a bit odd, would rather set it upfront and change the the isPBS branch to set each column explicitly, but has nothing to do with your patch directly and if, the cleanup should happen in a separate one in any way. > } > + me.extraColumns.vmid = { > + header: gettext('VMID'), > + dataIndex: 'vmid', > + hidden: true, > + sorter: (a, b) => a.data.vmid - b.data.vmid, doesn't this breaks, or at least behaves possibly confusingly, on custom file names? At least we don't handle the 'vmid' field explicitly in the 'pve-storage-content' model. Note that our regex here is very liberal, it basically returns any file that ends with tar or vma and an optional gz, lzo or zst compressor. > + }; > > me.callParent(); > > me.store.getSorters().clear(); > me.store.setSorters([ > - { > - property: 'vmid', > - direction: 'ASC', > - }, > { > property: 'vdate', > direction: 'DESC',